Skip to content

Conversation

@bembelimen
Copy link
Contributor

Summary of Changes

  • Moved cleanup functions to individual traits
  • Added traits to each plugin
  • Improved blog/categories views
  • Added global cleanup to schemaorg system plugin

Testing Instructions

  • Create different articles with schema information
  • Check head area of your page

Actual result BEFORE applying this Pull Request

  • empty values
  • wrong format for date/image/durations

Expected result AFTER applying this Pull Request

  • No empty values
  • Correct image/date/duration compilation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

brianteeman commented Jul 27, 2023

I am getting this in the frontendand admin for all the schema
example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

@bembelimen
Copy link
Contributor Author

I am getting this in the frontendand admin for all the schema example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

Thx,
tried here something which did not work anymore. Fixed it now.

@laoneo
Copy link
Member

laoneo commented Jul 28, 2023

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

@HLeithner
Copy link
Member

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

you only take the traits you need.

@Fedik
Copy link
Member

Fedik commented Aug 5, 2023

I have tested this item ✅ successfully on 7d87e4d

It is working from what I can see :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41260.

@HLeithner HLeithner merged commit fe2074e into joomla:5.0-dev Aug 5, 2023
@HLeithner
Copy link
Member

Thanks

richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
* Add json cleanup

* CS fix

* Fix deprecation and file name

* Fix deprecations

* Apply suggestions from code review

Co-authored-by: heelc29 <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Apply suggestions from code review

Co-authored-by: heelc29 <[email protected]>

* Fix namespace

* Activate cache by default

---------

Co-authored-by: heelc29 <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
* Add json cleanup

* CS fix

* Fix deprecation and file name

* Fix deprecations

* Apply suggestions from code review

Co-authored-by: heelc29 <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Apply suggestions from code review

Co-authored-by: heelc29 <[email protected]>

* Fix namespace

* Activate cache by default

---------

Co-authored-by: heelc29 <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
HLeithner pushed a commit that referenced this pull request Aug 20, 2023
* Add deleted files and folders and renamed files

- Deleted files and folders from PR #41276
- Renamed file from PR #41260

* Migrate enabled and params from old system plugin on update

* Remove deleted files and folders from PR #41276

These files and folders will be removed by the uninstallation of the plugin.

* Add exceptions to deleted file check script

These files and folders will be removed by the uninstallation of the plugin and therefore should not be added to the lists of deleted files and folders.

* Add deleted files and folders from PR #41289

* Add /media/plg_system_compat to exceptions

* Remove /media/plg_system_compat deleted files and folders

* Revert "Remove /media/plg_system_compat deleted files and folders"

This reverts commit ea429a6.

* Revert "Add /media/plg_system_compat to exceptions"

This reverts commit 296febf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants