-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.0] schema.org cleanup #41260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] schema.org cleanup #41260
Conversation
|
I am getting this in the frontendand admin for all the schema Php 8.1.10 |
Co-authored-by: heelc29 <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
Thx, |
|
What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.? |
you only take the traits you need. |
Co-authored-by: heelc29 <[email protected]>
…-cms into 5.0/schema-org-cleanup
|
I have tested this item ✅ successfully on 7d87e4d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41260. |
|
Thanks |
- Deleted files and folders from PR joomla#41276 - Renamed file from PR joomla#41260
* Add json cleanup * CS fix * Fix deprecation and file name * Fix deprecations * Apply suggestions from code review Co-authored-by: heelc29 <[email protected]> Co-authored-by: Brian Teeman <[email protected]> * Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php * Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php * Apply suggestions from code review Co-authored-by: heelc29 <[email protected]> * Fix namespace * Activate cache by default --------- Co-authored-by: heelc29 <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
* Add json cleanup * CS fix * Fix deprecation and file name * Fix deprecations * Apply suggestions from code review Co-authored-by: heelc29 <[email protected]> Co-authored-by: Brian Teeman <[email protected]> * Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php * Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php * Apply suggestions from code review Co-authored-by: heelc29 <[email protected]> * Fix namespace * Activate cache by default --------- Co-authored-by: heelc29 <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
- Deleted files and folders from PR joomla#41276 - Renamed file from PR joomla#41260
* Add deleted files and folders and renamed files - Deleted files and folders from PR #41276 - Renamed file from PR #41260 * Migrate enabled and params from old system plugin on update * Remove deleted files and folders from PR #41276 These files and folders will be removed by the uninstallation of the plugin. * Add exceptions to deleted file check script These files and folders will be removed by the uninstallation of the plugin and therefore should not be added to the lists of deleted files and folders. * Add deleted files and folders from PR #41289 * Add /media/plg_system_compat to exceptions * Remove /media/plg_system_compat deleted files and folders * Revert "Remove /media/plg_system_compat deleted files and folders" This reverts commit ea429a6. * Revert "Add /media/plg_system_compat to exceptions" This reverts commit 296febf.
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed