[5.0] Update deleted files and folders lists in script.php for 5.0.0-alpha4 #41393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
2 tasks
Fedik
reviewed
Aug 19, 2023
Member
Author
|
Closing in favor of the just merged PR #41394 . |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the lists of files and folders to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 5.0-dev branch in preparation for the upcoming 5.0.0-alpha4 release.
In detail deleted files and folder from following PR's are added:
'/templates/system/incompatible.html,/includes',
'/templates/system/incompatible.html,',
The following is not added due to deliberate decisions of the release managers:
Decision see [5.0] schemaorg filename #41261 (comment) .
Decision see [5.0] Move the compatibility plugin from system to behaviour folder #41276 (comment) .
The file from the first point not being renamed might cause schema.org for blog posts not working on Windows hosts after updates from previous 5.0 alpha versions.
The second point leaves an obsolete system plugin installed, which might cause issues when being activated when updating, and also after the update.
Therefore I have created PR #41394 to fix both mentioned points in case if the release managers think over their decision. That PR also includes the changes from this one here.
Testing Instructions
Code review.
Or if you want to make a real test, update a current 4.4-dev nightly build or a 5.0.0-alpha3 to the last 5.0 nightly build to get the actual result, and update a current 4.4-dev nightly build or a 5.0.0-alpha3 to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The files and folders mentioned above are still present after updating from a current 4.4-dev nightly build or a 5.0.0-alpha3.
Expected result AFTER applying this Pull Request
The files and folders mentioned above have been deleted after updating from a current 4.4-dev nightly build or a 5.0.0-alpha3.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed