Skip to content

Conversation

@richard67
Copy link
Member

Pull Request for Issue #41066 .

Summary of Changes

This pull request (PR) removes the obsolete assets com_users.admin-users-mail.es5 and com_users.admin-users-mail from file build/media_source/com_users/joomla.asset.json.

They should have been removed with #40302 , but that was overlooked since the original PR #39374 also had forgotten to remove them, so they were not added back later with PR #39431 and then were not marked as deprecated with PR #40385 .

Testing Instructions

On a clean, current 5.0-dev branch, run php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2 to get the actual result, and do the same on the branch of this PR to get the expected result.

Actual result BEFORE applying this Pull Request

> [email protected] versioning
> node build/build.js --versioning

[Error: ENOENT: no such file or directory, lstat '/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1687872657/media/com_users/js/admin-users-mail.min.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'lstat',
  path: '/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1687872657/media/com_users/js/admin-users-mail.min.js'
}
`npm run versioning` did not complete as expected.

Expected result AFTER applying this Pull Request

Build suceeds.

Link to documentations

Please select:

@dgrammatiko
Copy link
Contributor

@richard67 alternative: #41069

@HLeithner HLeithner merged commit fa4c211 into joomla:5.0-dev Jun 27, 2023
@richard67 richard67 deleted the 5.0-dev-fix-versioning branch June 27, 2023 15:08
@HLeithner HLeithner added this to the Joomla! 5.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants