Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue #41066 .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Broken

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

@dgrammatiko Shouldn't the unrelated changes in the html files be reverted?

@dgrammatiko
Copy link
Contributor Author

Aha, I didn't see that npm ci produced these. If this PR is preferred over the removal of the asset entries I will

@dgrammatiko dgrammatiko changed the title [5.0] Fixes the versioning of rpm tools [5.0] Fixes the versioning of npm tools Jun 27, 2023
@richard67
Copy link
Member

When we had the same issue in past, you had suggested a similar solution here #39408 (comment) , and I had made a PR with that: #39413 .

But this had caused a discussion, so I had closed that PR and had added back the assets with #39431 .

So I guess the same discussion "Ignoring missing files in build script is just asking for trouble." would again start here.

I think it's on @HLeithner to decide what he prefers, or if necessary discuss it with other maintainers.

@dgrammatiko
Copy link
Contributor Author

I'll close this one as I don't want to have the same conversation again...

@dgrammatiko dgrammatiko deleted the 5.0-dev-ver branch June 27, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants