-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] Massmail: Fix validation #39374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Quy done |
|
I have tested this item ✅ successfully on 5e9c489 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374. |
|
The deleted JS file will be added to the list of files to be deleted on update in script.php with another PR. I will care for that. |
|
I have tested this item ✅ successfully on 5e9c489 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374. |
|
Thank you Hannes @Hackwar for the PR! |
|
Documentation PR is wrong because it misses the removed JS file... this PR should have not been merged with a wrong documentation PR, also the documentation PR has to be merged at the same time as the PR it self.... |
|
Are you saying that we can't remove the JS? Or just to extend the documentation PR? |
This reverts commit eea6085.
…o be b/c for layout overrides (#39431)
Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.
Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.
COM_USERS_MAIL_PLEASE_FILL_IN_THE_FORM_CORRECTLY="Please fill in the form correctly." This string was marked as deprecated in joomla#39374 and removed from 5.0 as a result of the deprecation However this was in error as the string is used https://github.com/joomla/joomla-cms/blob/43a9aab4992d3048e8f2ee5091cd76959fc52acc/administrator/components/com_users/src/Model/MailModel.php#L126 This simple PR restores the string. I have made it against 5.0 as I see this as a bugfix but maintainers may decide its a new string and therefore must be in 5.1

Pull Request for Issue #33450.
Summary of Changes
Please see the original issue for the problem. Simply said, the mass mail feature has a custom, stupid form validation. This PR uses the default Joomla validation and also the default markup.
Testing Instructions
Actual result BEFORE applying this Pull Request
The form is not send and you get a blue box stating an error. Clicking again will add yet another blue box each time.
Expected result AFTER applying this Pull Request
Sending the form is prevented and all invalid fields are marked red. In addition, there is a message at the top. Clicking again will re-validate and only display one message at the top.
Link to documentations
Please select: