Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Dec 7, 2022

Pull Request for Issue #33450.

Summary of Changes

Please see the original issue for the problem. Simply said, the mass mail feature has a custom, stupid form validation. This PR uses the default Joomla validation and also the default markup.

Testing Instructions

  1. Go to mass mail in the users menu.
  2. Click on "Send Mail" (without filling out any data)

Actual result BEFORE applying this Pull Request

The form is not send and you get a blue box stating an error. Clicking again will add yet another blue box each time.

Expected result AFTER applying this Pull Request

Sending the form is prevented and all invalid fields are marked red. In addition, there is a message at the top. Clicking again will re-validate and only display one message at the top.

Link to documentations

Please select:

@Quy
Copy link
Contributor

Quy commented Dec 8, 2022

Add padding/spacing.

39374-padding

@Hackwar
Copy link
Member Author

Hackwar commented Dec 8, 2022

@Quy done

@richard67
Copy link
Member

I have tested this item ✅ successfully on 5e9c489


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.

@richard67
Copy link
Member

The deleted JS file will be added to the list of files to be deleted on update in script.php with another PR. I will care for that.

@MacJoom
Copy link
Contributor

MacJoom commented Dec 12, 2022

I have tested this item ✅ successfully on 5e9c489


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 12, 2022
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Dec 13, 2022
@obuisard obuisard merged commit 9b8e5bc into joomla:4.3-dev Dec 13, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 13, 2022
@obuisard
Copy link
Contributor

Thank you Hannes @Hackwar for the PR!

@HLeithner
Copy link
Member

Documentation PR is wrong because it misses the removed JS file... this PR should have not been merged with a wrong documentation PR, also the documentation PR has to be merged at the same time as the PR it self....

@Hackwar
Copy link
Member Author

Hackwar commented Dec 14, 2022

Are you saying that we can't remove the JS? Or just to extend the documentation PR?

@richard67
Copy link
Member

Are you saying that we can't remove the JS? Or just to extend the documentation PR?

@Hackwar That's actually subject of discussion in the maintainers channel on Mattermost and in my PR #39413 and in my previous PR #39408 .

richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022
obuisard pushed a commit that referenced this pull request Dec 17, 2022
@brianteeman brianteeman mentioned this pull request Apr 2, 2023
4 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2023
Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2023
Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.
@Hackwar Hackwar deleted the 4.3-massmail-1 branch April 17, 2023 07:37
HLeithner pushed a commit that referenced this pull request Jun 26, 2023
…#39374 (#40302)

* Finally delete deprecated javascript assets

Delete the js files and the asset once deleted with PR's #38823 and #39374 and then added back with PR #39431 for b/c reasons.

* Add the deleted files to script.php
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Nov 22, 2023
COM_USERS_MAIL_PLEASE_FILL_IN_THE_FORM_CORRECTLY="Please fill in the form correctly."

This string was marked as deprecated in joomla#39374 and removed from 5.0 as a result of the deprecation

However this was in error as the string is used https://github.com/joomla/joomla-cms/blob/43a9aab4992d3048e8f2ee5091cd76959fc52acc/administrator/components/com_users/src/Model/MailModel.php#L126

This simple PR restores the string.

I have made it against 5.0 as I see this as a bugfix but maintainers may decide its a new string and therefore must be in 5.1
@brianteeman brianteeman mentioned this pull request Nov 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants