[4.3] Create traits for the CMSObject error and property handling#39020
Merged
obuisard merged 2 commits intojoomla:4.3-devfrom Nov 9, 2022
Merged
[4.3] Create traits for the CMSObject error and property handling#39020obuisard merged 2 commits intojoomla:4.3-devfrom
obuisard merged 2 commits intojoomla:4.3-devfrom
Conversation
Member
Author
|
@wilsonge and @nikosdion feedback is appreciated |
2c16dd3 to
e993a85
Compare
|
I have tested this item ✅ successfully on e993a85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39020. |
rdeutz
approved these changes
Oct 24, 2022
wilsonge
approved these changes
Oct 24, 2022
Contributor
|
I am happy with this approach. |
Contributor
|
Thank you Allon @laoneo for the PR |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Split the
CMSObjectinto traits so extension developers can already use them and remove their dependency fromCMSObject. This pr is based on #38949 as it uses the exception trait.The traits are deprecated so people will understand their code should be changes accordingly to the deprecate messages. In 5.0 the dependencies to
CMSObjectare removed from core then and do use the traits to ensure nothing will break in 4.Testing Instructions
Load any back end view. CMSObject is used in tables and models so loading one of the views will use the CMSObject class.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Update new-deprecations.md for CMSObject Manual#50
No documentation changes for manual.joomla.org needed