[5.0] Switching Joomla\CMS\Filter\OutputFilter to Joomla\Filter\OutputFilter#40429
Merged
HLeithner merged 7 commits intojoomla:5.0-devfrom Jul 2, 2023
Merged
[5.0] Switching Joomla\CMS\Filter\OutputFilter to Joomla\Filter\OutputFilter#40429HLeithner merged 7 commits intojoomla:5.0-devfrom
HLeithner merged 7 commits intojoomla:5.0-devfrom
Conversation
4 tasks
Member
|
thanks |
HLeithner
added a commit
that referenced
this pull request
Jul 25, 2023
There was an error loading the language base path using the framework OutputFilter.
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
There was an error loading the language base path using the framework OutputFilter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We are using the Filter package from the framework, but still have also a Filter package in the CMS, which extends from the framework package. This PR switches all usages of the OutputFilter class to the framework package. The OutputFilter class can then be deprecated and removed in 6.0.
The two classes currently are not 100% identical. For that, the following PRs need to be merged into the framework first:joomla-framework/filter#56joomla-framework/filter#57The PRs have been merged. The dependency has been updated in here.
This PR also depends on #40432 to be merged first in order to fix the language dependency.The other PR has also been merged. We are ready to go!
Testing Instructions
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed