Adapting OutputFilter::stringUrlSafe() to CMS class#57
Merged
Conversation
Llewellynvdm
approved these changes
Apr 20, 2023
Contributor
Author
|
I'm closing this in favour of this being rebased to 2.0-dev to hopefully add this to Joomla 4.4 already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I'm trying to make the OutputFilter class from this package as compatible to the current CMS class as possible. This PR tries to achieve that with stringUrlSafe(). For this this one line was added. In addition, we have to add the language package as dependency to the CMS.
Testing Instructions
Documentation Changes Required