[5.0] Switching Input object from CMS to framework class#40415
Merged
laoneo merged 8 commits intojoomla:5.1-devfrom Feb 5, 2024
Merged
[5.0] Switching Input object from CMS to framework class#40415laoneo merged 8 commits intojoomla:5.1-devfrom
laoneo merged 8 commits intojoomla:5.1-devfrom
Conversation
Member
Author
|
Please note that the CMS Input package is still used in the CLI applications and there is no CLI replacement in the framework package, among other things because according to the docblocks the joomla/console package should be used instead. |
Member
|
This pull request has been automatically rebased to 5.1-dev. |
….0-input # Conflicts: # administrator/components/com_actionlogs/src/Controller/ActionlogsController.php # installation/src/Application/InstallationApplication.php # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/BaseApplication.php # libraries/src/Application/CMSApplication.php # libraries/src/Application/SiteApplication.php # libraries/src/Application/WebApplication.php
Member
Author
|
So, I looked into this again and the CliApplication class is deprecated and will be removed in 6.0. Since we are removing the CMS input class then as well, we can revert this change back and keep the CMS CLI Input class in that Application class. So after reverting that change, I'm marking this PR again as ready for review. |
Member
|
Merged, as they are only doc block changes. Thanks @Hackwar for this! |
LadySolveig
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 572f686.
bembelimen
pushed a commit
that referenced
this pull request
Feb 6, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
Joomla\CMS\Inputpackage has been deprecated and we have theJoomla\Input\Inputpackage from the framework instead. This converts all occurences of the CMS package over to the framework package. This especially fixes the issue that our application baseclass,Joomla\Application\AbstractWebApplication, uses the framework classes, while all child classes in the CMS use the CMS classes.This introduces a few b/c breaks, which I would consider acceptable, but also requires more work on the InputFilter class. The following issues have come up:
Joomla\Filter\InputFilter, while the CMS class uses the CMS InputFilter class. These 2 are not compatible right now, which is something we have to fix for the 3.0 release of the framework. The InputFilter framework class is lacking in functionality here.Joomla\CMS\Input\Cookie::set()currently accepts an array of values and then sets a cookie for each entry in the array, the framework doesn't have this feature.Joomla\CMS\Input\Files::get()has additional code to check for unsafe files, which would have to be added to the framework package.This PR also depends, among other things, on #40429.
Testing Instructions
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed