[4.2] quotation marks not speech marks #39677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces the use of speech marks in the language files with escaped quotation marks. This avoids the problem of a translator breaking their language pack by using non-escaped quotation marks instead of the speech marks.
Contributor
|
I have tested this item ✅ successfully on 4a2732b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39677. |
Member
|
thanks |
Contributor
Author
|
thanks - small change but it will prevent future issues |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 1, 2023
* Joomla 4.2.6 joomla/joomla-cms#39143 - (только для en-GB) joomla/joomla-cms#39317 - (исправлено ранее) * Joomla 4.2.7 joomla/joomla-cms#39376 + joomla/joomla-cms#39336 - (только для en-GB) joomla/joomla-cms#39629 - (только для en-GB) joomla/joomla-cms#37574 + joomla/joomla-cms#38781 - (только для en-GB) joomla/joomla-cms#39677 - (исправлено ранее) joomla/joomla-cms#39682 - (только для en-GB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of speech marks in the language files with escaped quotation marks.
This avoids the problem of a translator breaking their language pack by using non-escaped quotation marks instead of the speech marks.