-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] missing rel="noopener noreferrer" in link language string #39317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add [4.2] missing rel="noopener noreferrer"
|
I have tested this item ✅ successfully on 9649fd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317. |
|
Do we have that string elsewhere, e.g. in the language file for the api client or the site, where it should be fixed, too? Am off my desk now so can’t comfortably check. Update: I meanwhile checked. All fine, no other file with that string. |
|
I have tested this item ✅ successfully on 9649fd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317. |
@richard67 Thank you, your comment triggered me. We missed the installation folder:
and
|
@sandewt These are translations. If the English strings are ok, the translations have to be fixed on Crowdin, as far as I know. |
I also found the same issue in a language pack. I will pass this on to the relevant translator. |
|
Thank you! |
* Joomla 4.2.6 joomla/joomla-cms#39143 - (только для en-GB) joomla/joomla-cms#39317 - (исправлено ранее) * Joomla 4.2.7 joomla/joomla-cms#39376 + joomla/joomla-cms#39336 - (только для en-GB) joomla/joomla-cms#39629 - (только для en-GB) joomla/joomla-cms#37574 + joomla/joomla-cms#38781 - (только для en-GB) joomla/joomla-cms#39677 - (исправлено ранее) joomla/joomla-cms#39682 - (только для en-GB)
Pull Request for Issue # .
Summary of Changes
Add
rel="noopener noreferrer"in language stringTesting Instructions
Code review
Actual result BEFORE applying this Pull Request
Missing
rel="noopener noreferrer"in the language string, because the link containstarget="_blank"Expected result AFTER applying this Pull Request
Language string contains
rel="noopener noreferrer"Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed