Skip to content

Conversation

@sandewt
Copy link
Contributor

@sandewt sandewt commented Nov 26, 2022

Pull Request for Issue # .

Summary of Changes

Add rel="noopener noreferrer" in language string

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Missing rel="noopener noreferrer" in the language string, because the link contains target="_blank"

Expected result AFTER applying this Pull Request

Language string contains rel="noopener noreferrer"

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

add [4.2] missing rel="noopener noreferrer"
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Nov 26, 2022
@sandewt sandewt changed the title [4.2] missing rel="noopener noreferrer" in language string [4.2] missing rel="noopener noreferrer" in link language string Nov 26, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9649fd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.

@richard67
Copy link
Member

richard67 commented Nov 26, 2022

Do we have that string elsewhere, e.g. in the language file for the api client or the site, where it should be fixed, too? Am off my desk now so can’t comfortably check.

Update: I meanwhile checked. All fine, no other file with that string.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 9649fd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2022
@sandewt
Copy link
Contributor Author

sandewt commented Nov 26, 2022

Update: I meanwhile checked. All fine, no other file with that string.

@richard67 Thank you, your comment triggered me.

We missed the installation folder:

INSTL_DATABASE_VALIDATION_ERROR="Sprawdź swoje dane uwierzytelniające, typ bazy danych, nazwę bazy danych lub nazwę hosta. Jeśli masz zainstalowany MySQL 8, przeczytaj <a href=\"https://docs.joomla.org/Joomla_and_MySQL_8#Workaround_to_get_Joomla_working_with_MySQL_8\" target=\"_blank\">wiki</a>, aby uzyskać więcej informacji."

and

INSTL_DATABASE_HOST_IS_NOT_LOCALHOST_GENERAL_MESSAGE="正在尝试使用一个不在您本地服务器上的数据库主机。出于安全考虑,需要验证主机帐户的所有权。<a href=\"%s\" target=\"_blank\">请阅读文档</a> 获取更多信息"

@richard67
Copy link
Member

Update: I meanwhile checked. All fine, no other file with that string.

@richard67 Thank you, your comment triggered me.

We missed the installation folder:

INSTL_DATABASE_VALIDATION_ERROR="Sprawdź swoje dane uwierzytelniające, typ bazy danych, nazwę bazy danych lub nazwę hosta. Jeśli masz zainstalowany MySQL 8, przeczytaj <a href=\"https://docs.joomla.org/Joomla_and_MySQL_8#Workaround_to_get_Joomla_working_with_MySQL_8\" target=\"_blank\">wiki</a>, aby uzyskać więcej informacji."

and

INSTL_DATABASE_HOST_IS_NOT_LOCALHOST_GENERAL_MESSAGE="正在尝试使用一个不在您本地服务器上的数据库主机。出于安全考虑,需要验证主机帐户的所有权。<a href=\"%s\" target=\"_blank\">请阅读文档</a> 获取更多信息"

@sandewt These are translations. If the English strings are ok, the translations have to be fixed on Crowdin, as far as I know.

@sandewt
Copy link
Contributor Author

sandewt commented Nov 26, 2022

If the English strings are ok, the translations have to be fixed on Crowdin, as far as I know.

I also found the same issue in a language pack. I will pass this on to the relevant translator.

@MartijnMaandag

@laoneo laoneo merged commit 7afa3b7 into joomla:4.2-dev Nov 28, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 28, 2022
@laoneo
Copy link
Member

laoneo commented Nov 28, 2022

Thank you!

@laoneo laoneo added this to the Joomla! 4.2.6 milestone Nov 28, 2022
@sandewt sandewt deleted the patch-6 branch January 12, 2023 12:05
Kostelano added a commit to JPathRu/localisation that referenced this pull request Feb 1, 2023
* Joomla 4.2.6
joomla/joomla-cms#39143 - (только для en-GB)
joomla/joomla-cms#39317 - (исправлено ранее)

* Joomla 4.2.7
joomla/joomla-cms#39376 +
joomla/joomla-cms#39336 - (только для en-GB)
joomla/joomla-cms#39629 - (только для en-GB)
joomla/joomla-cms#37574 +
joomla/joomla-cms#38781 - (только для en-GB)
joomla/joomla-cms#39677 - (исправлено ранее)
joomla/joomla-cms#39682 - (только для en-GB)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants