-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] Download Key Filters #39376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Download Key Filters #39376
Conversation
The text says missing but the filter says invalid. They do not mean the same. The text says download key but the filter says valid but it doesn't validate the key it just says if the field has content or not
|
please could someone restart drone |
@brianteeman Did you mean this one? http://updates.myoldsite.com/file_null-1.0.zip I found it e.g. in PR #26769 . |
|
I have tested this item ✅ successfully on f6dd94a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376. |
yes that is the one |
|
I have tested this item ✅ successfully on f6dd94a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376. |
|
Thank you |
* Joomla 4.2.6 joomla/joomla-cms#39143 - (только для en-GB) joomla/joomla-cms#39317 - (исправлено ранее) * Joomla 4.2.7 joomla/joomla-cms#39376 + joomla/joomla-cms#39336 - (только для en-GB) joomla/joomla-cms#39629 - (только для en-GB) joomla/joomla-cms#37574 + joomla/joomla-cms#38781 - (только для en-GB) joomla/joomla-cms#39677 - (исправлено ранее) joomla/joomla-cms#39682 - (только для en-GB)
The text says missing but the filter says invalid. They do not mean the same.
The text says download key but the filter says valid but it doesn't validate the key it just says if the field has content or not
Strings now comply with style guide
Testing Instructions
Install at least one extension that requires a download key.
Test with a valid key
Test with an invalid key
Test without a key
Before
After
(I'm pretty sure there was a dummy extension needing a key that was created for testing and linked to somewhere here but I cant fint it right now)