[4.3] Migrate most components to the new toolbar api #39537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item 🔴 unsuccessfully on b4bab7d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537. |
Contributor
Author
|
IDs look fairly fixed. I can rebase this to 5.0 I guess - Depends how much we think IDs are a major b/c break in the backend. It's only the delete button that has the changed ID right? |
wilsonge
changed the title
wilsonge
changed the title
Member
|
@wilsonge what you mean with cache toolbar in the test instructions? Is just test the toolbar of each component right? Sorry for ask, just testing this PR, and for avoid do it wrong. |
Contributor
Author
|
Yes. Sorry originally the PR was just over com_cache but then I worked on some more components so need to update the instructions |
Contributor
Author
|
Final batch of components migrated. I suggest we test functionality here and I'll leave it to @joomla/cms-maintainers to decide if it needs to go to 4.3 or 5.0 and I'll happily rebase it to 5.0 if the IDs are deemed a concern. |
Member
|
Member
|
@wilsonge com_installer -> view=manage The button Install Extension: Undefined variable $url in ..www\bugtesting\joomla-cms\layouts\joomla\toolbar\link.php on line 34 |
Contributor
Author
|
Fixed! |
Quy
reviewed
Jan 12, 2023
administrator/components/com_associations/src/View/Association/HtmlView.php
Outdated
Show resolved
Hide resolved
…/HtmlView.php Co-authored-by: Quy <[email protected]>
Member
|
I have tested this item ✅ successfully on 4198356 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537. |
Quy
reviewed
Jan 16, 2023
administrator/components/com_contact/src/View/Contacts/HtmlView.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jan 16, 2023
administrator/components/com_config/src/View/Component/HtmlView.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jan 16, 2023
administrator/components/com_categories/src/View/Category/HtmlView.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jan 16, 2023
administrator/components/com_finder/src/View/Filter/HtmlView.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jan 16, 2023
administrator/components/com_templates/src/View/Template/HtmlView.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Jan 16, 2023
administrator/components/com_content/src/View/Featured/HtmlView.php
Outdated
Show resolved
Hide resolved
…w.php Shorter expression Co-authored-by: Quy <[email protected]>
…w.php Translated with 'close' by default Co-authored-by: Quy <[email protected]>
…View.php Translated with 'close' by default Co-authored-by: Quy <[email protected]>
Translated with 'close' by default Co-authored-by: Quy <[email protected]>
Quy
reviewed
Jan 18, 2023
administrator/components/com_installer/src/View/Manage/HtmlView.php
Outdated
Show resolved
Hide resolved
…w.php short version Co-authored-by: Quy <[email protected]>
short version Co-authored-by: Quy <[email protected]>
Contributor
|
I have tested this item ✅ successfully on 661f0b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 661f0b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39537. |
Contributor
|
Thank you George @wilsonge for this PR! |
richard67
pushed a commit
that referenced
this pull request
Feb 4, 2023
Pull Request for Issue #39537 .
2 tasks
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Apr 3, 2023
You can't have two buttons with the same text that do different things. I am assuming that this change was made in error by @wilsonge in joomla#39537 ### Joomla 4.29 ### Joomla 4.3 before this PR ### Joomla 4.3 after this PR
4 tasks
wilsonge
pushed a commit
that referenced
this pull request
Apr 3, 2023
You can't have two buttons with the same text that do different things. I am assuming that this change was made in error by @wilsonge in #39537 ### Joomla 4.29 ### Joomla 4.3 before this PR ### Joomla 4.3 after this PR Co-authored-by: Quy <[email protected]>
2 tasks
4 tasks
2 tasks
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Sep 15, 2023
The convention is that when it is a NEW item then its a cancel button and when editing an item its a close button. During the updates in joomla#39537 it looks like @wilsonge missed a few changes etc
4 tasks
wilsonge
pushed a commit
that referenced
this pull request
Sep 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Migrate the majority of core components towards the new toolbar API (notably I'm skipping Joomla Update as part of this PR and the use of ToolbarHelper::modal in com_templates views which probably need to be moved to the popupButton - but that's a bigger piece of work for another PR)
Testing Instructions
Check all the toolbar icons work the same before and after the patch is applied across all backend components
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed