[5.0] toolbar cancel or close button #41764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convention is that when it is a NEW item then its a cancel button and when editing an item its a close button. During the updates in joomla#39537 it looks like @wilsonge missed a few changes etc
|
I have tested this item ✅ successfully on 306dc4e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764. |
wilsonge
approved these changes
Sep 15, 2023
Contributor
|
I have tested this item ✅ successfully on 306dc4e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764. |
Contributor
|
Thanks! |
Contributor
Author
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention is that when it is a NEW item then its a cancel button and when editing an item its a close button.
During the updates in #39537 it looks like @wilsonge missed a few changes etc
Testing Instructions
For the components updated check that it correctly uses the close or cancel button text
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed