Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jul 24, 2023

Summary of Changes

Apply changes from #39537 for new debugging features (#36753)

Testing Instructions

check button still work and are rendered correctly for LTR and RTL

image
image

Actual result BEFORE applying this Pull Request

works

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

actually Toolbar::getInstance() is deprecated, so it doesn't makes it better. I'm planing to move the instance to the document but didn't had the time yet to implement it...

@heelc29
Copy link
Contributor Author

heelc29 commented Jul 25, 2023

so it doesn't makes it better

Ok, but then we have only to replace how we get the toolbar instance like in all the other components ...

@HLeithner
Copy link
Member

I added the toolbar to the document in #41254 and used your PR as first example for the usage.

@heelc29
Copy link
Contributor Author

heelc29 commented Jul 26, 2023

Close in favor of #41254

@heelc29 heelc29 closed this Jul 26, 2023
@heelc29 heelc29 deleted the 5.0/finder/toolbar-api branch July 26, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants