Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Dec 30, 2022

Pull Request for Issue #38828 .

Summary of Changes

This is an alternative PR to #39335, it improves the debug view of permissions for usergroups.
Same code as in #37807 plus #39481

Testing Instructions

Look at usergroups, permissions for a group

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

+100 for consistency with the other tables

@richard67
Copy link
Member

@chmst Please fix the code style errors reported here: https://ci.joomla.org/joomla/joomla-cms/60418/1/8 .

@richard67
Copy link
Member

Something I don’t understand: The description says

Same code as in #37807 plus #39481

Both mentioned PR‘s have been merged into 4.2-dev, so if that statement was true, this PR here should show zero changes.

@chmst
Copy link
Contributor Author

chmst commented Dec 30, 2022

@richard67 the logic of the newly added code is the same, the layout and indetion of lines itself is slightly different.

@Quy
Copy link
Contributor

Quy commented Jan 23, 2023

Please fix conflicts.

@Hackwar Hackwar added the Feature label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 5.0-dev May 8, 2023 15:02
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@ChrisHoefliger
Copy link

I have tested this item ✅ successfully on 8b8058a

Tested successfully on localhost Joomla 4.3.4 PBF 2023


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39525.

@rachelwalraven
Copy link

I have tested this item ✅ successfully on 8b8058a

Tested succesfully on joomla 5.0 php 8.1.22


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39525.

@joomla-cms-bot joomla-cms-bot removed Feature PBF Pizza, Bugs and Fun labels Aug 26, 2023
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@richard67 richard67 added Feature PBF Pizza, Bugs and Fun PR-5.0-dev and removed PR-4.3-dev labels Aug 26, 2023
@joomla-cms-bot joomla-cms-bot added PR-4.3-dev and removed Feature RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun PR-5.0-dev labels Aug 26, 2023
@RickR2H
Copy link
Member

RickR2H commented Aug 26, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@richard67 richard67 added Feature PBF Pizza, Bugs and Fun PR-5.0-dev and removed PR-4.3-dev labels Aug 26, 2023
@bembelimen bembelimen added PR-4.3-dev and removed Feature RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun PR-5.0-dev labels Aug 26, 2023
@bembelimen
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@HLeithner HLeithner merged commit be0b3cc into joomla:5.0-dev Sep 12, 2023
@HLeithner
Copy link
Member

this has many RTCs^^ thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.