-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] Reduce number of permission columns #37807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on b71a3a6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37807. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on b71a3a6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37807. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37807. |
Quy
reviewed
May 17, 2022
Co-authored-by: Quy <[email protected]>
Member
|
I've restored the previous results from human tests in the issue tracker since the commit after that was just a code style change regarding white space. |
Contributor
|
Thanks everybody |
This was referenced Sep 24, 2022
Contributor
|
Unfortunately this PR is not correct and creates errors and misleading information See #38781 (comment) |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The permissions overview contains 5 columns which contain always the same value because these are global permissions.
This PR extracts global permissions from the list of possible actions and displays the result in a single line.
It does not resolve the issue #23628. Horizontal scrolling appears in all screens where the table heading enforces horizontal scrolling, not only here. As soon as the table width cannot be reduced to fit the viewport, a horizontal scrollbar appears.
We resolve this in other tables by hiding some olumns, but on the permissions this is not possible.
Testing Instructions
Have a look on the permissions of a user before and after the patch.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
yes