-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2 #39401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2 #39401
Conversation
|
Due to a discussion in my other PR #39413 I'd like to have a decision if I shall remove the following lines from this PR https://github.com/joomla/joomla-cms/pull/39401/files#diff-db7eb77540ff419bd7e6557d2779f4cf1e31158c20cb4b63dbbe8d6c426385adR6486-R6491 , therefore I set the RLDQ label. |
|
We have discussed in the CMS Maintainers team. I will modify this PR here on Friday because I don't have the time today and tomorrow. As it looks now (still collecting opinions), the JS files will be removed from the list of files to be deleted on update. |
|
Thank you, Richard @richard67, as always. |
Pull Request for Issue # .
Summary of Changes
Update the section comments for deleted files and folders for 4.3 and to the current 4.3.0-alpha1.
Update deleted files to changes from following PRs:
/plugins/content/emailcloak/emailcloak.php/plugins/content/fields/fields.phpFor the same reason, the deleted js files from PR [4.3] Massmail: Fix validation #39374 are not added to the list with change 2. above.
The broken build will be fixed with another PR, see discussion in my PR's [4.3] Fix broken package build after merge of PR #39374 #39408 and [4.3] Handle missing file in updateAsset method of the versioning js when building packages #39413 .
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.3.0-alpha1 or any older 4.x version to the last 4.3 nightly build to get the actual result, and update a 4.3.0-alpha1 or any older 4.x version to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
Files and folders mentioned at item 2 of the description above are still present after updating from a 4.3.0-alpha1 or any older 4.x version.
Expected result AFTER applying this Pull Request
All files and folders mentioned at item 2 of the description above have been deleted after updating from a 4.3.0-alpha1 or any older 4.x version.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed