Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Dec 12, 2022

Pull Request for Issue # .

Summary of Changes

  1. Update the section comments for deleted files and folders for 4.3 and to the current 4.3.0-alpha1.

  2. Update deleted files to changes from following PRs:

  1. Remove js files from PR [4.3] Template Diff View #38823 from the deleted files list because we have to keep them for b/c of layout overrides.
    For the same reason, the deleted js files from PR [4.3] Massmail: Fix validation #39374 are not added to the list with change 2. above.
    The broken build will be fixed with another PR, see discussion in my PR's [4.3] Fix broken package build after merge of PR #39374 #39408 and [4.3] Handle missing file in updateAsset method of the versioning js when building packages #39413 .

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.3.0-alpha1 or any older 4.x version to the last 4.3 nightly build to get the actual result, and update a 4.3.0-alpha1 or any older 4.x version to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

Files and folders mentioned at item 2 of the description above are still present after updating from a 4.3.0-alpha1 or any older 4.x version.

Expected result AFTER applying this Pull Request

All files and folders mentioned at item 2 of the description above have been deleted after updating from a 4.3.0-alpha1 or any older 4.x version.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [4.3] [WiP] Update deleted files list in script.php for upcoming 4.3.0-alpha2 [4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2 Dec 13, 2022
@richard67
Copy link
Member Author

Due to a discussion in my other PR #39413 I'd like to have a decision if I shall remove the following lines from this PR https://github.com/joomla/joomla-cms/pull/39401/files#diff-db7eb77540ff419bd7e6557d2779f4cf1e31158c20cb4b63dbbe8d6c426385adR6486-R6491 , therefore I set the RLDQ label.

@richard67
Copy link
Member Author

We have discussed in the CMS Maintainers team. I will modify this PR here on Friday because I don't have the time today and tomorrow. As it looks now (still collecting opinions), the JS files will be removed from the list of files to be deleted on update.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 14, 2022
@richard67 richard67 removed Updates Requested Indicates that this pull request needs an update from the author and should not be tested. RMDQ ReleaseManagerDecisionQueue labels Dec 16, 2022
@richard67
Copy link
Member Author

I've updated this PR here in order not to delete the js files which were removed with PR's #38823 and #39374 . So this PR is ready now.

@obuisard
Copy link
Contributor

I've updated this PR here in order not to delete the js files which were removed with PR's #38823 and #39374 . So this PR is ready now.

Thank you Richard, very appreciated.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Dec 17, 2022
@obuisard obuisard merged commit b27f23a into joomla:4.3-dev Dec 17, 2022
@obuisard
Copy link
Contributor

Thank you, Richard @richard67, as always.

@richard67 richard67 deleted the 4.3-dev-deleted-files-and-folders-2022-12-12 branch December 17, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants