[4.2] Inject the db into the MVC layer

[laoneo]

Summary of Changes

Injects the database instance into the model. So we don't have to rely on the global db anymore. Additionally it deprecates the use of the database in the model constructor and uses the aware interface and trait from the db package.

Testing Instructions

• Browse around in the back end and front end of Joomla
• Open the back end user list view
• Open the back end modules list view

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

[wilsonge]

This looks wrong to me. The only place that should be database aware is the model. All controller and views database queries should be eventually moved into the model. not be made database aware

[joeforjoomla]

This looks wrong to me. The only place that should be database aware is the model. All controller and views database queries should be eventually moved into the model. not be made database aware

Totally agree with @wilsonge

[laoneo]

This looks wrong to me. The only place that should be database aware is the model. All controller and views database queries should be eventually moved into the model. not be made database aware

I agree too, and the problem is that there are queries which do not actually fit into a model, for example against the extensions table. I mean I can move all of them to the model of the view, but would be nicer to have them just from the beginning on the right place.

[wilsonge]

This looks better. I don't think that factory should be databaseaware. Just the model. But definitely better than what we had before.

[laoneo]

True, removed the interface.

[BPBlueprint]

I have tested this item ✅ successfully on 67cdd83

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37095.}

[roland-d]

Thank you everybody