-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] Create the field in the base model when it doesn't exist #37636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
and that's why I said low level changes like #37095 should have better testing instructions and automated tests |
|
Confirming that it fixes the broken pr Wondring why the url contains an empty clientid This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636. |
|
I have tested this item ✅ successfully on 8a2c824 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636. |
|
The pr #37095 is actually shipped with unit tests and the base model is tested with almost every system test we have. For sure there are always edge cases where something can break. In this case it broke because a model has an undeclared variable which is bad coding practice and will produce an error in PHP 9, when the RFC passes https://wiki.php.net/rfc/undefined_property_error_promotion. |
|
I have tested this item ✅ successfully on 8a2c824 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636. |
|
Thanks everybody |
Summary of Changes
The database model has since #37095 a magic method to deliver the _dbo variable. This function needs to create the properties when they do not exist.
Testing Instructions
Edit a module in the back end.
Actual result BEFORE applying this Pull Request
The following error happens:
_Attempt to assign property "params" on null _
Expected result AFTER applying this Pull Request
Module form shows up.