Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Apr 24, 2022

Summary of Changes

The database model has since #37095 a magic method to deliver the _dbo variable. This function needs to create the properties when they do not exist.

Testing Instructions

Edit a module in the back end.

Actual result BEFORE applying this Pull Request

The following error happens:
_Attempt to assign property "params" on null _

Expected result AFTER applying this Pull Request

Module form shows up.

@brianteeman
Copy link
Contributor

and that's why I said low level changes like #37095 should have better testing instructions and automated tests

@brianteeman
Copy link
Contributor

Confirming that it fixes the broken pr

Wondring why the url contains an empty clientid


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 8a2c824


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.

@laoneo
Copy link
Member Author

laoneo commented Apr 24, 2022

The pr #37095 is actually shipped with unit tests and the base model is tested with almost every system test we have. For sure there are always edge cases where something can break. In this case it broke because a model has an undeclared variable which is bad coding practice and will produce an error in PHP 9, when the RFC passes https://wiki.php.net/rfc/undefined_property_error_promotion.

@alikon
Copy link
Contributor

alikon commented Apr 25, 2022

I have tested this item ✅ successfully on 8a2c824


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.

@alikon
Copy link
Contributor

alikon commented Apr 25, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 25, 2022
@roland-d roland-d merged commit 8b58e2d into joomla:4.2-dev Apr 25, 2022
@roland-d roland-d deleted the j4/model/fields branch April 25, 2022 17:40
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 25, 2022
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants