Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Feb 19, 2022

Pull Request for pr #37095.

Summary of Changes

Injects the database instance into the forms and form fields.

Testing Instructions

  • In the file /libraries/src/Form/Form.php add the following code after line 1629:
    echo 'NOT INJECTED!';die;
  • Open the article form.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working, the form loads and "NOT INJECTED!" is not displayed on the page.

@laoneo laoneo marked this pull request as ready for review April 14, 2022 11:54
@laoneo laoneo force-pushed the j4/db/inject-field branch 2 times, most recently from 94f142c to b92d089 Compare April 14, 2022 12:35
@laoneo laoneo force-pushed the j4/db/inject-field branch from b92d089 to f16b86f Compare April 14, 2022 12:40
@brianteeman
Copy link
Contributor

From the information provided its impossible to test.

@laoneo
Copy link
Member Author

laoneo commented Apr 20, 2022

Just open the article form, either in the back end and front end. Make sure there is no error. As this change injects the database into the form, every form field is affected and no "Database must be set, this will not be caught anymore in 5.0." message is added to the deprecate log.

@laoneo
Copy link
Member Author

laoneo commented Apr 22, 2022

Updated the testing instructions.

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@roland-d roland-d merged commit 3215c9f into joomla:4.2-dev May 10, 2022
@roland-d roland-d deleted the j4/db/inject-field branch May 10, 2022 16:33
@roland-d
Copy link
Contributor

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PBF Pizza, Bugs and Fun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants