Change warning descriptions for minimum to 16MB #35909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In administrator/components/com_installer/src/Model/WarningsModel.php the minimum required value for both post_max_size and upload_max_filesize is set to 16MB ($minMemory). The warning descriptions should reflect that.
Pull Request for Issue # (N/A).
Summary of Changes
Correct minimum value in warning descriptions.
Testing Instructions
Set post_max_size and upload_max_filesize to 10MB in /etc/php.ini.
Actual result BEFORE applying this Pull Request
Got these 2 warnings in System -> Information -> Warnings, even though those values are larger than the minimum required shown in the warnings:
"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 8MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."
"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 8MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."
Expected result AFTER applying this Pull Request
The correct warnings should be:
"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 16MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."
"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 16MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."
Documentation Changes Required
None