Skip to content

Conversation

@kochinc
Copy link
Contributor

@kochinc kochinc commented Oct 26, 2021

In administrator/components/com_installer/src/Model/WarningsModel.php the minimum required value for both post_max_size and upload_max_filesize is set to 16MB ($minMemory). The warning descriptions should reflect that.

Pull Request for Issue # (N/A).

Summary of Changes

Correct minimum value in warning descriptions.

Testing Instructions

Set post_max_size and upload_max_filesize to 10MB in /etc/php.ini.

Actual result BEFORE applying this Pull Request

Got these 2 warnings in System -> Information -> Warnings, even though those values are larger than the minimum required shown in the warnings:

"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 8MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."

"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 8MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."

Expected result AFTER applying this Pull Request

The correct warnings should be:

"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 16MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."

"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 16MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."

Documentation Changes Required

None

In administrator/components/com_installer/src/Model/WarningsModel.php the minimum required value for both post_max_size and upload_max_filesize is set to 16MB. The warning descriptions should reflect that.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Oct 26, 2021
@richard67
Copy link
Member

I have tested this item ✅ successfully on 053a0ae

The change of the messages is correct.

The corresponding change of the minimum sizes from 8 to 16 MB has been made with PR #34754 here https://github.com/joomla/joomla-cms/pull/34754/files#diff-0998cd4637eab77ec0459b0d09df3bf6c093d012ed0ec6e7f5ab3f19bd9c3a6c

Tested by code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

@richard67
Copy link
Member

P.S.: The string "COM_INSTALLER_MSG_WARNINGS_MEDMEMORYDESC" seems to be already ok, i.e. it seems to reflect already the change from PR #34754 , so the fix made here seems to be complete.

@Quy
Copy link
Contributor

Quy commented Oct 28, 2021

I have tested this item ✅ successfully on 053a0ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

@Quy Quy removed Language Change This is for Translators PR-4.0-dev labels Oct 28, 2021
@Quy
Copy link
Contributor

Quy commented Oct 28, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 28, 2021
@Quy Quy added PR-4.0-dev RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Oct 28, 2021
@richard67 richard67 added the Language Change This is for Translators label Oct 28, 2021
@bembelimen bembelimen merged commit 1ee5fb4 into joomla:4.0-dev Nov 2, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 2, 2021
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants