[4.0] Improve updater layout

[bembelimen]

Summary of Changes

This PR improves the Joomla! updater layout and adds some structure:

Initial layout

When we're in the initial state and did not check for the update yet, the following screen is visible:

Old

New

As you can see I used the emptystate function, which was implemented a few weeks ago (also in later stages). I also removed the information of the currently installed version, as it gives no benefit in the current state.

Last but not least the "Upload & Update" is moved down in a text link, as I assume upload updates are not that common.

No update found

Now we press the "Check for updates" without finding an update.

Old

and

New

As you can see, there is no pre-update check, because....there is no update. But the button changes to offer the re-installation of the core files. Also all this unnecessary verbose information were removed.

Update found

Next test is, if there is an update.

Old

and

New

and

and

and

Here the strange fieldsets are were removed and the information are split into different tab-pills. The update is moved to a 2nd step. Verbose information like current version and the download link are removed (no download needed here, see below in upload area). An additional checkbox is displayed for an extra confirmation regarding backups. Also the confirmation regarding extensions with update required is there.

The pills (left side) show an status icon, for extensions it's an animated hourclass till all extensions are checked.

Update via upload

Last but not least the update via upload.

Old

and

New

and

Here, if a update file is available as download, it's offered to the user to download. Headline of the Login is not "Login" anymore, because the user is already logged in. Also the backup confirmation is here again.

Update

The update did not change.

Testing Instructions

It's a bit hard to test. What I did was to install an Joomla! RC2 and replace the administrator/com_joomlaupdate and media/com_joomlaupdate folders from the download of this PR (see link at the bottom). Also the language file needs to be updated and layouts/joomla/content/emptystate.php has to be copied.

Then you can go through all the steps of the update.

For reinstall, you can use the normal patchtester.

Actual result BEFORE applying this Pull Request

Update works but layoutit a bit confusing.

Expected result AFTER applying this Pull Request

Update still works with new layout.

Additional comment

Help pages has the wrong link.

TODO

• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment) intended behaviour
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)
• [4.0] Improve updater layout #34754 (comment)

[chmst]

I have tested this item ✅ successfully on 005fdd1

Tested following the testing instructions.

To complete the test, the layout layouts/joomla/content/emptystate.php is needed.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34754.}

[Quy]

Using custom URL: https://update.joomla.org/core/nightlies/next_major_list.xml

Clicking the icon goes to this screen. Clicking Check for Updates button display Checked for updates. message.

[bembelimen]

Using custom URL: https://update.joomla.org/core/nightlies/next_major_list.xml

Clicking the icon goes to this screen. Clicking Check for Updates button display Checked for updates. message.

Hi thanks for the feedback, that is "intended" (or not different to the old version): #34754 (comment)

But probably we should change the title to "your current version is xxx" instead of "check if an update is available".

[Quy]

Before PR, I got this:

[Quy]

Plus the quickicon is misleading giving the impression that there is an update to perform.

[bembelimen]

Yeah, but can you rewrite the files in the 2nd tab?

[Quy]

[bembelimen]

I'm using:

and get:

[Quy]

I installed the prebuilt package: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34754/downloads/45766/

The custom URL is same as yours but I don't get the same result.

[wilsonge]

Works for me too :/

[wilsonge]

Thankyou!

[particthistle]

I'm getting same as @Quy - I too installed the prebuilt package, so that's perhaps the difference there... is it a timing issue on the nightly build?

[particthistle]

But now it's merged, that might make a difference when applied in the next nightly build and RC4.

[bembelimen]

Especially thanks @brianteeman for the big review and @Quy for the improvements.
Also thanks for the testers

[richard67]

Sorry I just see I was wrong regarding the place in script.php where the deleted files should be added.

Not for the reasons which @brianteeman stated above - what I wrote about where things belong to is still right.

But I was missing the fact that in 3.10 these files are at another place (administrator/components/com_joomlaupdate/views/default/tmpl) and so the J3 files are already present in the "From 3.10 to 4.0" section, and the J4 files removed with this PR here should be moved to section "4.0 from RC 3 to RC 4" in the deleted files list in script.php.

I will make a PR to fix that.

[brianteeman]

lol

[richard67]

lol

@brianteeman Are you perfect so you never make mistakes? I am not, and I am aware of this and able to correct them, in opposite to other people around. And it changes nothing on what I have said about how that deleted files and folder lists are currently structured.

[richard67]

See #34784 .