Removed Complete & from open site and open admin button

[khu5h1]

Pull Request for Issue #18833 (part).

Summary of Changes

Removed Complete & from the open site and open admin buttons in all languages.

Testing Instructions

Install Joomla and after its successful installation, the Congratulations page will have Open site and Open admin buttons.

Actual result BEFORE applying this Pull Request

Complete & appeared on the installation completion page.

Expected result AFTER applying this Pull Request

Complete & is removed from the installation completion page.

Documentation Changes Required

No

[richard67]

It needs to adapt system tests to the changed button texts, see the log here: https://ci.joomla.org/joomla/joomla-cms/48299/1/22

[richard67]

Question: Do you really speak all these languages for which you have changed the text? Or have you just removed the first 2 words everywhere without understanding what they mean?

I would expect that this PR changes only the English (GB) texts and leaves the translations to the translation teams.

[khu5h1]

Hey @richard67, Thank you for your feedback. I am trying to figure out a way to solve the failing test. Apart from this, I have used Google Translator and have translated all the languages. Then, accordingly, I have committed the changes.

[khu5h1]

By the way, May you please help me with some code pointers/references to solve the failing tests.

[richard67]

@khu5h1 Am not familiar with these tests either but will try to find someone who is.

[khu5h1]

Sure @richard67 , I will try to figure out the solution to the failing tests.

[Kubik-Rubik]

@khu5h1 Thanks for the PR! Please do not modify language files of languages you are not speaking fluently (best practice: only update the main language file en-GB). We have dedicated translation teams with native speakers who will take care of it!

Your change will let this test to fail:

You need to update this test as well to pass the check.

[dgrammatiko]

The changes should be reflected here: https://github.com/joomla-projects/joomla-browser/blob/95e099d99044ba9915d0d99b31028b723e2fc7e4/src/JoomlaBrowser.php#L306

[wojsmol]

@khu5h1 As a member of Polish translation team I support many request above to revert changes to languages other then en-GB.

[wojsmol]

@khu5h1 If you revert changes to languages other then English then I will make PR to fix tests.

[wojsmol]

Related PR created joomla-projects/joomla-browser#223

[wojsmol]

I have tested this item ✅ successfully on 213ac48

on code review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[manav014]

I have tested this item ✅ successfully on 213ac48

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[richard67]

Unfortunately this PR solves the mentioned issue only partly. It removes the "Complete &" but still leaves 2 buttons. So it seems we have to leave that issue open.

[khu5h1]

Yeah, we shall keep that issue open and I will create a separate PR for the remaining changes.

[richard67]

@khu5h1 Then it would be good if you could change the text at the top of your PR's description to show that it solves the issue only party, e.g. by changing from "Pull Request for Issue #18833 ." to "Pull Request for Issue #18833 (part).". Thanks in advance.

[brianteeman]

#18833 (comment)

[richard67]

#18833 (comment)

@khu5h1 Could you check this comment in the issue? I think it is right, the naming we use is "Administrator" and not "Admin".

@wojsmol If that has been done, could you adjust your PR for the tests?

Thanks in advance both.

I know, it was wrong all the time before, but it would make sense to fix it here and not need another PR for that which again will have to change the tests in the other repository, too.

[richard67]

Back to pending due to requested changes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[khu5h1]

I also think that it is good to change admin to Administrator. I have committed the requested changes.:)

[wojsmol]

I have tested this item ✅ successfully on d0a87b3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[wojsmol]

@richard67 PR in the other repo updated as requested.

[richard67]

@wojsmol Thanks.

[manav014]

I have tested this item ✅ successfully on d0a87b3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35988.}

[khu5h1]

Thank you Everyone for your comments and feedback. :)

[bembelimen]

Thx