[4.0] Move deletion of com_joomlaupdate files to the right place in script.php (was my mistake) #34784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for #34754 (comment) .
Summary of Changes
Move the files which have been removed in RC 4 with PR #34754 to the right section of the deleted files list in script.php.
They have been added to section "From 3.10 to 4.0" of the $files array by PR #34754 due to my advise.
But I was missing the fact that these templates were at a different place in J3, and these J3 files are already deleted on update, so the deletion of the J4 files due to PR #34754 belongs to section "4.0 from RC 3 to RC 4".
This PR here fixes my mistake so the deleted files list in script.php is consistent with what the tool (build/deleted_file_check.php) creates when being used in the right way.
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// From 3.10 to 4.0" section of the $files array.
Expected result AFTER applying this Pull Request
Files which have been removed in 4.0 RC 4 due to PR #34754 are located in the "// 4.0 from RC 3 to RC 4" section of the $files array.
Documentation Changes Required
None.