Skip to content

Conversation

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Apr 23, 2021

Summary of Changes

So I mentioned about the possibility of blank states in Joomla 4 as a comment on someone's PR a long time ago. It received quite a bit of positive feedback but no one has actually attempted it

So here is "an attempt"

The concept is that rather than a new user getting a first time out of the box experience with "no matching results" or a state that is unhelpful, that the user receives a welcome and an introduction to each area.

This PR is a PROOF OF CONCEPT for Articles ONLY - if it received praise then I might do the others, and others can join in too..

The blank state template is ONLY USED when you have no articles in your database. It is NOT used if a search/filter produces no results (in that case, you would correctly get "No Matching Results" message like you currently do.

To be clear

This is not a new concept. Everyone else is already doing it.

More examples of Empty State Design:
https://www.toptal.com/designers/ux/empty-state-ux-design

Testing Instructions

Apply PR on a site with no articles.
Add article - blank state design disappears and you see a list of articles
filter the articles by something (search for kashfdksjhgfkjsdhf) and see that you DONT see the blank slate but you DO get "No Matching Results"
Trash your article - and see that you DONT see the blank slate
Empty your trash (leaving ZERO articles in the db) and see that you DO now see the blank slate

Actual result BEFORE applying this Pull Request

At the moment the out of the box experience (without demo data) is a bunch of left menu items that all lead to blank pages saying "no matching results"

User is "welcomed" to Joomla with a negative messages

Screenshot 2021-04-23 at 14 27 04

Expected result AFTER applying this Pull Request

Empty State Design / Blank state Design pattern is used.

Documentation Changes Required

Screenshots.

Screenshot 2021-04-23 at 15 15 55

Signed-off-by: Phil E. Taylor <[email protected]>

Remote h/w

Signed-off-by: Phil E. Taylor <[email protected]>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Apr 23, 2021
@richard67
Copy link
Member

@PhilETaylor Please remove any emojis from title and description of PRs. They can confuse our CI tools.

@richard67
Copy link
Member

... and the issue tracker can be confused, too.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

Beside the above comment (which is fixed now), I like this PR. Much more user friendly way to show there are no items.

@brianteeman
Copy link
Contributor

  1. As a non-coder I didn't understand what you meant by blankstate. Now I understand it to mean "no records yet" ?
  2. Can you add aria-hidden="true" to the icon please
  3. The voice you have used for the message is very informal, which is fine, but everywhere else we use a more formal voice such as "No articles have been created yet,"

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Actually I can see now that I test it that the text you propose is not correct as it is displayed when you have created articles they just are trashed.

And if you have trashed all the articles then there is no way to select them to permanently delete or to restore them (unless you create a new article). So I guess the check for "blankstate" is not correct.

Signed-off-by: Phil E. Taylor <[email protected]>
@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Same thing happens if I only have unpublished items. So there is a bug there.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Something weird is going on - trying to replicate it reliably

Co-authored-by: Brian Teeman <[email protected]>
@Bond97
Copy link

Bond97 commented Apr 23, 2021

I think, that it will be better to add this page "looks like..." to other menu items under the same visibility conditions: categories, featured articles, fields, field groups and menus.

@PhilETaylor what do you think about it?

@brianteeman
Copy link
Contributor

OK so if you set a filter and the filter returns no results you get the blank state which is clearly not what you intended.

issue

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

issue

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Phil I can replicate it in any scenario where there are no matching results and I assume that you only meant this to be displayed when there are no records at all

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

Signed-off-by: Phil E. Taylor <[email protected]>
@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Yes that did it. This is a great improvement.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

@PhilETaylor I guess that was it. But it's not only PostgreSQL which requires it, MySQL would require it too if sunning in strict mode, Oracle would require it (if we would support that).

@PhilETaylor

This comment was marked as abuse.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Apr 23, 2021
See joomla#33264 for instructions but this time for newsfeeds and not content

This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php
@PhilETaylor

This comment was marked as abuse.

@wilsonge
Copy link
Contributor

I love this :) Lets get some tests and get it in. Thankyou so much!!

@TLWebdesign
Copy link

I have tested this item ✅ successfully on 8d3accc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264.

@RickR2H
Copy link
Member

RickR2H commented Apr 23, 2021

I have tested this item ✅ successfully on 8d3accc

Very nice feature! Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264.

@richard67
Copy link
Member

I've advertised a bit a JoomlaDay USA, so we did not have to wait very long for testers 😄

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 23, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 23, 2021
@PhilETaylor

This comment was marked as abuse.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Apr 23, 2021
See joomla#33264 for instructions but this time for Users: Privacy and not content

This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php

Note that there is no button to add a new consent
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Apr 23, 2021
See joomla#33264 for instructions but this time for user notes  and not content

This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Apr 23, 2021
See joomla#33264 for instructions but this time for user orubate messages and not content

This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php
@rdeutz rdeutz merged commit b95a479 into joomla:4.0-dev Apr 24, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.