-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[4] Introducing Joomla’s first blank state #33264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Phil E. Taylor <[email protected]> Remote h/w Signed-off-by: Phil E. Taylor <[email protected]>
|
@PhilETaylor Please remove any emojis from title and description of PRs. They can confuse our CI tools. |
|
... and the issue tracker can be confused, too. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Beside the above comment (which is fixed now), I like this PR. Much more user friendly way to show there are no items. |
|
This comment was marked as abuse.
This comment was marked as abuse.
|
Actually I can see now that I test it that the text you propose is not correct as it is displayed when you have created articles they just are trashed. And if you have trashed all the articles then there is no way to select them to permanently delete or to restore them (unless you create a new article). So I guess the check for "blankstate" is not correct. |
Signed-off-by: Phil E. Taylor <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
administrator/components/com_content/tmpl/articles/blankstate.php
Outdated
Show resolved
Hide resolved
|
Same thing happens if I only have unpublished items. So there is a bug there. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
Something weird is going on - trying to replicate it reliably |
Co-authored-by: Brian Teeman <[email protected]>
|
I think, that it will be better to add this page "looks like..." to other menu items under the same visibility conditions: categories, featured articles, fields, field groups and menus. @PhilETaylor what do you think about it? |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
Phil I can replicate it in any scenario where there are no matching results and I assume that you only meant this to be displayed when there are no records at all |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: Phil E. Taylor <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
|
Yes that did it. This is a great improvement. |
This comment was marked as abuse.
This comment was marked as abuse.
|
@PhilETaylor I guess that was it. But it's not only PostgreSQL which requires it, MySQL would require it too if sunning in strict mode, Oracle would require it (if we would support that). |
This comment was marked as abuse.
This comment was marked as abuse.
See joomla#33264 for instructions but this time for newsfeeds and not content This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php
administrator/components/com_content/tmpl/articles/blankstate.php
Outdated
Show resolved
Hide resolved
This comment was marked as abuse.
This comment was marked as abuse.
|
I love this :) Lets get some tests and get it in. Thankyou so much!! |
|
I have tested this item ✅ successfully on 8d3accc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264. |
|
I have tested this item ✅ successfully on 8d3accc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264. |
|
I've advertised a bit a JoomlaDay USA, so we did not have to wait very long for testers 😄 |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33264. |
This comment was marked as abuse.
This comment was marked as abuse.
See joomla#33264 for instructions but this time for Users: Privacy and not content This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php Note that there is no button to add a new consent
See joomla#33264 for instructions but this time for user notes and not content This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php
See joomla#33264 for instructions but this time for user orubate messages and not content This PR requires the code from joomla#33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php


Summary of Changes
So I mentioned about the possibility of blank states in Joomla 4 as a comment on someone's PR a long time ago. It received quite a bit of positive feedback but no one has actually attempted it
So here is "an attempt"
The concept is that rather than a new user getting a first time out of the box experience with "no matching results" or a state that is unhelpful, that the user receives a welcome and an introduction to each area.
This PR is a PROOF OF CONCEPT for Articles ONLY - if it received praise then I might do the others, and others can join in too..
The blank state template is ONLY USED when you have no articles in your database. It is NOT used if a search/filter produces no results (in that case, you would correctly get "No Matching Results" message like you currently do.
To be clear
This is not a new concept. Everyone else is already doing it.
More examples of Empty State Design:
https://www.toptal.com/designers/ux/empty-state-ux-design
Testing Instructions
Apply PR on a site with no articles.
Add article - blank state design disappears and you see a list of articles
filter the articles by something (search for kashfdksjhgfkjsdhf) and see that you DONT see the blank slate but you DO get "No Matching Results"
Trash your article - and see that you DONT see the blank slate
Empty your trash (leaving ZERO articles in the db) and see that you DO now see the blank slate
Actual result BEFORE applying this Pull Request
At the moment the out of the box experience (without demo data) is a bunch of left menu items that all lead to blank pages saying "no matching results"
User is "welcomed" to Joomla with a negative messages
Expected result AFTER applying this Pull Request
Empty State Design / Blank state Design pattern is used.
Documentation Changes Required
Screenshots.