Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Apr 23, 2021

image

See #33264 for instructions but this time for banners and not content

This PR requires the code from #33264 to be merged first - specifically the change in libraries/src/MVC/Model/ListModel.php

added a docs links

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Apr 23, 2021
@ChristineWk
Copy link

I have tested this item ✅ successfully on 0e1b469

Test was possible, after applying also the other PR in addition


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33269.

@RickR2H
Copy link
Member

RickR2H commented Apr 24, 2021

I have tested this item ✅ successfully on 0e1b469


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33269.

@alikon
Copy link
Contributor

alikon commented Apr 24, 2021

the drone failure is unrelated to this pr

@alikon
Copy link
Contributor

alikon commented Apr 24, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33269.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed Language Change This is for Translators PR-4.0-dev labels Apr 24, 2021
@richard67 richard67 added Language Change This is for Translators PR-4.0-dev labels Apr 24, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 24, 2021
@rdeutz rdeutz merged commit 13cfd2b into joomla:4.0-dev Apr 24, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 24, 2021
@brianteeman
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants