Skip to content

Comments

[4.0] Remove com_admin profile view#32933

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
joomdonation:remove_com_admin_profile_view
Mar 30, 2021
Merged

[4.0] Remove com_admin profile view#32933
wilsonge merged 2 commits intojoomla:4.0-devfrom
joomdonation:remove_com_admin_profile_view

Conversation

@joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Mar 30, 2021

Pull Request for Issue # .

Summary of Changes

The PR #32771 was merged, so view profile in com_admin is not used anymore, thus it could be removed.

Testing Instructions

As it is not used, I don't know what should be testing instructions. Could it be merged on review @wilsonge ?

Or

  1. Enable at least one 2fa plugin
  2. Setup "enforce 2fa" within the Users -> Manage -> Options
  3. Make sure that you are redirected to edit user account page (before it's com_admin but now it is com_users)

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Mar 30, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7b7c1d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933.

@zero-24
Copy link
Contributor

zero-24 commented Mar 30, 2021

@joomdonation
Copy link
Contributor Author

Thanks @zero-24 . Could you please take a look at my last commit to see if it is OK? I don't use two factor authentication nor know how it works to check and confirm that myself.

@zero-24
Copy link
Contributor

zero-24 commented Mar 30, 2021

Looks good on a quick look but should be added to the testing instructions

  • apply this PR
  • enable atleast one 2fa plugin
  • setup "enforce 2fa" within the Users -> manage -> options
  • make sure that you are redirected to com_users vs com_admin before

@joomdonation
Copy link
Contributor Author

Thanks @zero-24. I updated the testing instructions with your suggestions.

@wilsonge
Copy link
Contributor

Looks like RIPs is down. But I'm happy to get this in to solve our release blocker given brians' good test and tobias review of the 2FA section. We can find the rest on general testing

@wilsonge wilsonge merged commit d32b9d5 into joomla:4.0-dev Mar 30, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 30, 2021
@ceford
Copy link
Contributor

ceford commented Mar 30, 2021

Grrrrr! I have been developing a site that uses profile view. One difference is that registered users are not allowed to change Username in the profile view but they are in the user view. Another is the absence of the User Status toggle. Does changing that to Blocked result in the user blocking himself? A Manager does not have access to the User component so needs to use the Edit Account button from the User Menu in the Title Bar.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933.

@joomdonation
Copy link
Contributor Author

@ceford : Don't worry. User can edit their account from administrator area of your site now directly via com_users (not depend on his user group). It is the result of this PR #32771

@ceford
Copy link
Contributor

ceford commented Mar 30, 2021

A Manager group user does not have a Users item in the left menu (good) so needs to use the top right User Menu -> Edit Account item (good). But, the User Options form has a Change Username option which is set to No and that is being ignored in the form. The Username can be changed. So I am worried!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933.

@joomdonation
Copy link
Contributor Author

A Manager group user does not have a Users item in the left menu (good) so needs to use the top right User Menu -> Edit Account item (good). But, the User Options form has a Change Username option which is set to No and that is being ignored in the form. The Username can be changed. So I am worried!

Thanks @ceford . I think we can come up with a solution for this problem. I will make a PR for that later. Anything else you concern about the change from com_admin to com_users?

@ceford
Copy link
Contributor

ceford commented Mar 30, 2021

Anything else you concern about the change from com_admin to com_users?

In profile view the Login Name field has a descriptor - useful when that field is disabled. And the Receive System Emails field is not present in the profile view. I am not sure what is meant by System in this case. For example, does that include the email containing a pw reset token? Or emails from custom applications. I would like it be configurable so anyone less than Super Administrator cannot change it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Mar 31, 2021
Post joomla#32933 update the list of files and folders in script.php
@joomdonation joomdonation deleted the remove_com_admin_profile_view branch March 31, 2021 15:11
This was referenced Mar 31, 2021
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Apr 24, 2023
These language strings are not used in Joomla 4. They were added to address an issue with joomla#31884 but then the entire view was removed with joomla#32933

Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right
laoneo pushed a commit that referenced this pull request May 2, 2023
These language strings are not used in Joomla 4. They were added to address an issue with #31884 but then the entire view was removed with #32933

Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants