[4.0] Remove com_admin profile view#32933
Conversation
|
I have tested this item ✅ successfully on 7b7c1d0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933. |
|
That code path has to be adjusted too: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Application/CMSApplication.php#L1291-L1324 |
|
Thanks @zero-24 . Could you please take a look at my last commit to see if it is OK? I don't use two factor authentication nor know how it works to check and confirm that myself. |
|
Looks good on a quick look but should be added to the testing instructions
|
|
Thanks @zero-24. I updated the testing instructions with your suggestions. |
|
Looks like RIPs is down. But I'm happy to get this in to solve our release blocker given brians' good test and tobias review of the 2FA section. We can find the rest on general testing |
|
Grrrrr! I have been developing a site that uses profile view. One difference is that registered users are not allowed to change Username in the profile view but they are in the user view. Another is the absence of the User Status toggle. Does changing that to Blocked result in the user blocking himself? A Manager does not have access to the User component so needs to use the Edit Account button from the User Menu in the Title Bar. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933. |
|
A Manager group user does not have a Users item in the left menu (good) so needs to use the top right User Menu -> Edit Account item (good). But, the User Options form has a Change Username option which is set to No and that is being ignored in the form. The Username can be changed. So I am worried! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933. |
Thanks @ceford . I think we can come up with a solution for this problem. I will make a PR for that later. Anything else you concern about the change from com_admin to com_users? |
In profile view the Login Name field has a descriptor - useful when that field is disabled. And the Receive System Emails field is not present in the profile view. I am not sure what is meant by System in this case. For example, does that include the email containing a pw reset token? Or emails from custom applications. I would like it be configurable so anyone less than Super Administrator cannot change it. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32933. |
Post joomla#32933 update the list of files and folders in script.php
These language strings are not used in Joomla 4. They were added to address an issue with joomla#31884 but then the entire view was removed with joomla#32933 Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right
These language strings are not used in Joomla 4. They were added to address an issue with #31884 but then the entire view was removed with #32933 Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right
Pull Request for Issue # .
Summary of Changes
The PR #32771 was merged, so view profile in com_admin is not used anymore, thus it could be removed.
Testing Instructions
As it is not used, I don't know what should be testing instructions. Could it be merged on review @wilsonge ?
Or