[4.0] Allow users edit account via com_users without core.manager permission

[joomdonation]

Pull Request for Issue #30217.

Summary of Changes

This PR allows users to edit their account from administrator area of the site without requiring to have core.manager permission. If it is accepted, it will solve the release blocker issue #30217. Also, it allows us to removing the code which we have to add to com_admin to allow editing profile at the moment.

Testing instructions

• Apply patch.
• Create a user account, assign this account to Manager user group
• Login to administrator account of the site using that manager account
• Try to access to User Account section at the top right of administrator area, click on Edit Account and Accessibility Settings, make sure you can still access to the page and update the account data without any problem.

[brianteeman]

In principle yes this is how I see it being done

[joomdonation]

@brianteeman Could you please try it quickly to see what is missing or still need to be addressed?

[brianteeman]

From my quick test with both a manager and super administrator account this PR works correctly and is how it should have been done from the beginning without all the duplication of code in com_admin

[richard67]

@joomdonation Event if it’s draft status you should fix the PHPCS (code style) errors reported by drone, because only if these pass the system tests will be run, and those would show if there was a mistake.

[richard67]

The main change here is it allows user to edit his own account ...

@joomdonation Should the title of the PR be changed from "[4.0] Allow Managers to edit account via com_users" to "[4.0] Allow Managers to edit own account via com_users"?

[joomdonation]

@richard67 Yes. I changed it to a better title (describe exactly what PR does)

[richard67]

@joomdonation Your last commit changed the since tag at the wrong place. the old function should remain 1.6 and the new one should get deploy version, but you did it vice versa ;-)

[joomdonation]

Thanks @richard67. Hope it is all OK now. On top of my head, this PR is now ready for reviewing and testing. Hopefully we can close the release blocker issue #30217

[richard67]

@joomdonation

Hope it is all OK now.

Yes, code looks ok and clean to me.

Hopefully we can close the release blocker issue #30217

You mean this PR solves it? If you confirm, I will close it.

[richard67]

Added the release blocker label as inherited from the issue.

[joomdonation]

@richard67 Yes, I think we can close that issue. Even if this PR is not accepted, I think most users can agree that it is not release blocker anymore (the problem right now is just duplication code which is solved if this PR is accepted)

[richard67]

Even if this PR is not accepted, I think most users can agree that it is not release blocker anymore (the problem right now is just duplication code which is solved if this PR is accepted)

@joomdonation You mean I should remove the release blocker label from this PR?

[richard67]

Back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32771.}

[alikon]

setting back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32771.}

[alikon]

got this on pdo with 8.0.23

[joomdonation]

So the problem is that PDO return string data type for User ID but MySQLi return int data type . I was not sure about it and that was the reason I used weak comparison at the begininging

I made modification as suggested. I tested it myself with both PDO and MySQLi, it is working well now. Please test it again. Thanks all for reviewing and testing and sorry for taking so much time from you for this PR.

[rdeutz]

I have tested this item ✅ successfully on f47df46

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32771.}

[joomdonation]

@brianteeman Could you please re-test this PR?

[dgrammatiko]

I have tested this item ✅ successfully on f47df46

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32771.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32771.}

[wilsonge]

Thankyou so much guys. Much appreciated!