[4.0] Check if parent class exists in renderfield#32783
Merged
richard67 merged 1 commit intojoomla:4.0-devfrom Mar 21, 2021
Merged
[4.0] Check if parent class exists in renderfield#32783richard67 merged 1 commit intojoomla:4.0-devfrom
richard67 merged 1 commit intojoomla:4.0-devfrom
Conversation
laoneo
changed the title
Member
|
Merged on review of code of this PR and #32488 . |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for pr #32488.
Summary of Changes
The new parent class doesn't exist on every occasion. A check if it exists removes a warning. Discovered while running the system tests of DPCalendar on J4.
Merge on code review @wilsonge.