[4.0] Decouple messages from core.js

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

• This PR moves the core.js logic for rendering messages to another file
• It uses import for bringing in the alert custom element (one less HTTP request)

Why?

Well, there is no way to override this part of the code without overriding the whole core.js, which is terrible as this is supposed to be the javascript API of the CMS. Bad architecture.

Depends/extends #32740

Testing Instructions

• Apply the PR
• try to login with the wrong credential in the front end and back end (should get an alert)
• Try to upload an image in the media manager (you should also get an alert)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Not really, the code is the same, we only moved it to an own file that is included from the respective layout (thus is properly overridable now)

[Quy]

Please fix conflicts. Thanks.

[Quy]

Go to Smart Search.
Click Clear Index button.

Before PR:

After PR (missing first message):

[dgrammatiko]

@Quy thanks for testing, it seems a bug with (animation transition [?]) alerts custom element as the HTML part was created correctly

[dgrammatiko]

@Quy 268a29e should fix it

[Quy]

Fixed, however, the first message is colored blue and not green.

[Quy]

Go to System > Redirects
Click Redirect System Plugin in the alert.

Alert should be red.
Modal does not open.

[dgrammatiko]

Modal does not open.

Say hello to HTML sanitization, will check this

[dgrammatiko]

@Quy fixed both, I have to alter also the other PR for the allowed attributes

[Quy]

Go to Media.
Click Delete button.

Alert should be red.

[dgrammatiko]

Alert should be red.

So I thought that I could drop the old strings but I guess that will be B/C break, so they're back

[Quy]

Looks good!! I will test some more.

In the meantime, if you can look at these related issues: #30880 #29152

Thanks!

[dgrammatiko]

@Quy #32868 should solve both the issues

[particthistle]

I have tested this item 🔴 unsuccessfully on aa80075

Last moment test fail :(

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32747.}

[dgrammatiko]

Last moment test fail :(

What failed?

[particthistle]

Doh! Comment got lost as I was editing it.

• The items on your test list all passed.
• The items @Quy tested I also tested and they also passed. The note on the link colour on the redirect plugin IMO isn't an issue - in Beta 8 it's green. After applying your PR, it's also green. @Quy suggested it should be red. The modal there did work.
  

The error encountered was in Joomla Update.

After testing, I went to reinstall Beta 7 to then update to Beta 8. Got to the point where I logged into Joomla Update and it was about to start unpacking the archive, and this AJAX error came up, rendering the update process broken.

[dgrammatiko]

After testing, I went to reinstall Beta 7 to then update to Beta 8. Got to the point where I logged into Joomla Update and it was about to start unpacking the archive, and this AJAX error came up, rendering the update process broken.

This is not related to alerts AFAICT, something else is broken there as that is a native confirm not the alerts that this PR is patching

[particthistle]

I have tested this item ✅ successfully on aa80075

Thanks for looking at that so quickly.
I've just tested the Joomla Update process again and it worked successfully

I think I'd broken it by clicking Apply Patch instead of installing the download package at the start of the process.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32747.}

[Quy]

I have tested this item ✅ successfully on aa80075

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32747.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32747.}