Skip to content

Comments

[4.0] Blog layout ux#32943

Merged
rdeutz merged 30 commits intojoomla:4.0-devfrom
chmst:blog-layout-ux
Apr 24, 2021
Merged

[4.0] Blog layout ux#32943
rdeutz merged 30 commits intojoomla:4.0-devfrom
chmst:blog-layout-ux

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Mar 31, 2021

Pull Request for Issue #32012 .

Summary of Changes

J4 uses css grid classes for the multi column presentation of blogs. This is done via modifying classes as described here: #18319.

For users, espcially for users who migrate from J3 this is not self explaining, they ares used do define a fixed number of columns and display diretion.

This PR enables both, using own classes - but also defining a number of columns and a output direction.
This PR uses classes from #32488 for the blog layout tab where the blog lyout is definedt. This should be self explaining

It accepts columns and ordering for blog layouts in two extra fields. The input in these fields is converted to css grid classes columns-x or mansonry-x in the respective layouts. Please see comment #32943 (comment)
grafik

If this is accepted, the migration script from j3.10 to 4.0 ist no longer necessary.

Testing Instructions

Testing of this step is easy, just apply the patch, set your global params in content options. A
Add new menu Items to category blogs, play around with settings, or change existing menuItems of this type.

Documentation Changes Required

yes

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Mar 31, 2021
@brianteeman
Copy link
Contributor

I have had a super quick look before jumping to a day long meeting. Looks great!!!!

One suggestion would be to use different terminology to J3 and J4. A user might be new to joomla and so it wont meaning anything to them.

Not sure what to call the J3 version - perhaps "fixed count"
For the J4 how about "CSS grid"

@brianteeman brianteeman mentioned this pull request Mar 31, 2021
@brianteeman
Copy link
Contributor

Please add the release blocker label

chmst and others added 2 commits March 31, 2021 12:14
@richard67
Copy link
Member

A question which is related to this PR and might have to be handled with another, new PR is the handling of updates from 3.10.

With PR #31570 , a migration of the old J3 blog layout parameters to the new css classes on update has been implemented.

When this PR here will be merged, it might sense to think about reverting it so people keep their old J3 values on update, and having the Joomla 3 way as default (params value in db) for the new created field here, while for new installations the default would be the Joomla 4 way.

@chmst
Copy link
Contributor Author

chmst commented Mar 31, 2021

@richard67 thanks, your link is the correct one.
The script should add the param blog_style = 3 and let other params untouched.

@brianteeman
Copy link
Contributor

Why do we even need the script any more

/me always reluctant to touch user data

@richard67
Copy link
Member

The script should add the param blog_style = 3 and let other params untouched.

@chmst You mean when updating from 3.10 leave other params untouched? This would mean to revert #31570 almost completely. When updating previous 4.0 Beta versions, the blog classes created by the conversion from that PR would be not touched. Or did you mean let other params untouched compared to what we have now in 4.0-dev without this PR? I think you meant the 1st way, updating from 3.10, but as I'm not sure if I understand right, I'm asking.

@chmst
Copy link
Contributor Author

chmst commented Mar 31, 2021

I see two cases: In both of them, the script is used but simplified:

From 3.10 to 4: I would use the script und add the param "blog_style":"3" to params

From 4.0 beta to 4.0: I would use the script und add the param "blog_style":"4" to params


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@brianteeman
Copy link
Contributor

From 3.10 to 4: I would use the script und add the param "blog_style":"3" to params

Cant it be 3 by default? Then you dont need to change anything

Re the name I really am not in favour of anything be labelled "Joomla 3 style" Firstly the user may never have used Joomla before so it is a meaningless term to them. Secondly if you wanted to be really accurate then it would be "Joomla 1 style"

chmst added 4 commits April 12, 2021 16:25
# Conflicts:
#	components/com_content/tmpl/category/blog.xml
#	components/com_content/tmpl/featured/default.xml
@michwebdev
Copy link

I have tested this item ✅ successfully on d236a2e

What I observed is that the patch makes changes to a blog menu item configuration in the Blog Layout editing tab. The patched version is a more intuitive layout.

One issue I noticed with the layout is that when the screen width is under 1450 px, the "Multi Column Direction" and "Date for Ordering" fields extend outside of the border around the editing area.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@BrentCritch
Copy link

I have tested this item ✅ successfully on d236a2e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@richard67
Copy link
Member

One issue I noticed with the layout is that when the screen width is under 1450 px, the "Multi Column Direction" and "Date for Ordering" fields extend outside of the border around the editing area.

That's a know issue, we are working on it.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 23, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 23, 2021
@cdguillaudeu
Copy link

I have tested this item ✅ successfully on d236a2e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@frostmakk
Copy link
Contributor

Another wasted opportunity to give new users the wow experience that Joomla needs right now.
CSS grid is a novelty in J, and classes are the new toys to play with.
Give the users a proper interface with classes to choose from, not this unclear halfway something solution.
This is just sad.

@richard67
Copy link
Member

Another wasted opportunity to give new users the wow experience that Joomla needs right now.
CSS grid is a novelty in J, and classes are the new toys to play with.
Give the users a proper interface with classes to choose from, not this unclear halfway something solution.
This is just sad.

@frostmakk You are just ignoring here the answers you have already been given in previous comments. This PR removes nothing of the flexibility you have for that which is already there in J4, it just offers an additional possibility to do it also in the other way which many people seem to prefer.

@N6REJ
Copy link
Contributor

N6REJ commented Apr 23, 2021

If they have to do that then Joomla is dead in the water

They don't have to.
They will do it in pure joy over the powers given to them.

not at all! I can tell you as a VERY experienced person that the minute you start trying to "make life simple" for me, you hinder me greatly and make my job 100x harder.
A simple example is helix. powerful UI.. nightmare for me to "customize" to the degree that I'm paid for from within the ui itself.

@Quiviro
Copy link

Quiviro commented Apr 23, 2021

I have tested this item ✅ successfully on 4ef5eee

I changed the content options of the menu item and it reflects in the blog layout


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@TLWebdesign
Copy link
Contributor

I have tested this item ✅ successfully on 4ef5eee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32943.

@frostmakk
Copy link
Contributor

Is my English really that bad?
None of You have understood what I am trying to communicate.

@chmst
Copy link
Contributor Author

chmst commented Apr 23, 2021

@frostmakk maybe my understanding of English is so bad. This is what I understand.
You would like the opportunity to use the full concept of css grid classes for the blog Layout. And you think that our layout should prepare all possibilities in a way that they must not know the grid concept or classes.

@frostmakk
Copy link
Contributor

I would like the users to be able to do a lookup of all the available classes in the template, and select the combinations they want.
The lookup and selection could be a separate popup window or whatever you call a dialogue form.
The input field should then be populated with the selection.
Experienced users can put whatever they want in the input fields without using the lookup.

@rdeutz rdeutz merged commit ec6e6a5 into joomla:4.0-dev Apr 24, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 24, 2021
@frostmakk
Copy link
Contributor

Sacrificed on the Release Blocker altar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.