[4.0] Fix js ajax for pre update checker#29980
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Jul 19, 2020
Merged
Conversation
joomla-cms-bot
added
NPM Resource Changed
Fedik
reviewed
Jul 5, 2020
Contributor
Author
|
I have updated the test instructions because the Pre-Checker was not triggered in the default configuration. |
degobbis
force-pushed
the
j4dev/fixAjaxUpdateChecker
branch
from
7d3ac74 to
f0f1cd1
Compare
Contributor
|
I have tested this item ✅ successfully on f0f1cd1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980. |
Contributor
|
Result after patch This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980. |
|
I have tested this item ✅ successfully on d876f4c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980. |
Contributor
Author
|
RTC |
Contributor
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980. |
Contributor
|
Thanks! |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jul 21, 2020
…outs * '4.0-dev' of github.com:joomla/joomla-cms: (612 commits) [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474) [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007) [4.0] Get menu directly in com_tags menu route helper (joomla#30039) Remove collapse when resizing from mobile to desktop (joomla#30132) [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870) [4.0] Webauthn gmp warning (joomla#29731) [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694) [4.0] CLI help text (joomla#29811) Feature/draggable typo fixes (joomla#29987) [4.0] Removing unnecessary workaround in finder indexer (joomla#30037) [4.0] Optimizing Smart Search for larger content (joomla#30008) [4.0] Fix js ajax for pre update checker (joomla#29980) [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097) [4.0][com_fields] Fix draggable sorting (joomla#30094) [4.0] Correct incorrect @return documentation (joomla#30092) [4.0] Menu items modal: adding missing filters (joomla#30087) short to long php open tags with echo (joomla#30089) Use new Toolbar (joomla#30085) [4.0] Center status/date created headers (joomla#29249) [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077) ... # Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php # installation/sql/postgresql/base.sql # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/SiteApplication.php
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix js ajax for pre update checker
Testing Instructions
[update 07.07.2020]
Optionson the right cornerUpdate ChaneltoCustom UrlMinimum StabilitytoDevelopmenthttps://update.joomla.org/core/nightlies/next_major_list.xmlasCustom URLthanSave and closeActual result BEFORE applying this Pull Request
Notice the pre update checker cant find the combat tag
All installed extensions show the flag: Missing Compatibility Tag
Expected result AFTER applying this Pull Request
The pre update checker can now find the combat tag (npm required)
All installed extensions without update server show the flag:
Missing Compatibility TagAll installed extensions with update server but without update block with a
<targetplatform>tag for Joomla 4 show the flag:NoAll installed extensions with update server and an update block with a
<targetplatform>tag for Joomla 4 show the flag:Yes