Skip to content

[4.0] Fix js ajax for pre update checker #29980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 4 commits into from
Jul 19, 2020
Merged

[4.0] Fix js ajax for pre update checker #29980

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c2cf20
[4.0] Fix js ajax for pre update checker
degobbis Jul 5, 2020
f0f1cd1
encodeURIComponent
degobbis Jul 5, 2020
241f3c9
Merge branch '4.0-dev' into j4dev/fixAjaxUpdateChecker
degobbis Jul 11, 2020
d876f4c
Merge branch '4.0-dev' into j4dev/fixAjaxUpdateChecker
degobbis Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions build/media_source/com_joomlaupdate/js/default.es5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,15 @@ Joomla = window.Joomla || {};

// Request the server to check the compatiblity for the passed extension and joomla version
Joomla.request({
url: PreUpdateChecker.config.serverUrl,
data: {
'joomla-target-version': PreUpdateChecker.joomlaTargetVersion,
'extension-id': node.getAttribute('data-extensionId')
},
url: PreUpdateChecker.config.serverUrl
+ '&joomla-target-version=' + encodeURIComponent(PreUpdateChecker.joomlaTargetVersion)
+ '&extension-id=' + encodeURIComponent(node.getAttribute('data-extension-id')),
onSuccess(data) {
var response = JSON.parse(data);
// Extract the data from the JResponseJson object
extension.state = response.data.state;
extension.compatibleVersion = response.data.compatibleVersion;
extension.currentVersion = node.getAttribute('data-extensionCurrentVersion');
extension.currentVersion = node.getAttribute('data-extension-current-version');

// Pass the retrieved data to the callback
callback(extension);
Expand Down