Feature/draggable typo fixes#29987
Feature/draggable typo fixes#29987richard67 merged 6 commits intojoomla:4.0-devfrom hans2103:feature/draggable-typo-fixes
Conversation
joomla-cms-bot
added
NPM Resource Changed
|
I found 29 instances before patching and 18 after - all in media / system / js which I did not rebuild. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987. |
|
@ceford That is due to the fact that all files in /media are in .gitignore This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987. |
|
The media folder should not have that any more after running npm. An other way to test that would be the pre build packages there npm should have rebuild them already. |
|
@zero-24 is there anything I have to change on my PR? |
No all is fine :) |
|
I have tested this item ✅ successfully on 1923fb5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987. |
1 similar comment
|
I have tested this item ✅ successfully on 1923fb5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987. |
|
Can you please update to include changes in #30094? |
|
@Quy merged changes and found two new files with |
|
I have added the merge in commit hans2103@89c852e They are in branch https://github.com/hans2103/joomla-cms/commits/feature/draggable-typo-fixes |
|
They have been added to your PR here. See e7490ea Thank you!!! |
|
@Quy yes! Now I see them too. |
|
Thanks! |
…outs * '4.0-dev' of github.com:joomla/joomla-cms: (612 commits) [4.0] Smart Search: Fixing ordering, order direction and disabled button (joomla#29474) [4.0] Generate routed Modal links for iframes when not on the root (joomla#30007) [4.0] Get menu directly in com_tags menu route helper (joomla#30039) Remove collapse when resizing from mobile to desktop (joomla#30132) [4.0] Wrap component output in `main` element to make Cassiopeia more accessible (joomla#29870) [4.0] Webauthn gmp warning (joomla#29731) [4.0] Refactor to return early, remove if depths and throw NotAllowed (joomla#29694) [4.0] CLI help text (joomla#29811) Feature/draggable typo fixes (joomla#29987) [4.0] Removing unnecessary workaround in finder indexer (joomla#30037) [4.0] Optimizing Smart Search for larger content (joomla#30008) [4.0] Fix js ajax for pre update checker (joomla#29980) [4.0] Cassiopea: Fixing modals custom-select fields display (joomla#30097) [4.0][com_fields] Fix draggable sorting (joomla#30094) [4.0] Correct incorrect @return documentation (joomla#30092) [4.0] Menu items modal: adding missing filters (joomla#30087) short to long php open tags with echo (joomla#30089) Use new Toolbar (joomla#30085) [4.0] Center status/date created headers (joomla#29249) [4.0] Fix Cassiopea searchtools alignment in modals (joomla#30077) ... # Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php # installation/sql/postgresql/base.sql # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/SiteApplication.php
Replace "dragable" by "draggable" * Searched for dragable and replaced by draggable
7 participants
Pull Request for Issue # .
Summary of Changes
continue from #29984 (comment)
Searched for
dragableand replaced bydraggable