Skip to content

Comments

[4.0] Move Searchtools styling to template#27416

Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom
Fedik:searchtools-move-to-tmpl
Jan 6, 2020
Merged

[4.0] Move Searchtools styling to template#27416
HLeithner merged 3 commits intojoomla:4.0-devfrom
Fedik:searchtools-move-to-tmpl

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Jan 6, 2020

Summary of Changes

This will move searchtools styling to the template files.
More info in #27384 comments.

Testing Instructions

Apply patch, run npm install

Expected result

All works

Actual result

Almost works, with some rtl issue

@infograf768 please check

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 6, 2020
@Fedik Fedik mentioned this pull request Jan 6, 2020
@infograf768
Copy link
Member

Let's go for it.
We can correct some more stuff after merge.
Some are in _toolbar.scss

@wilsonge @HLeithner

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 789eabc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

@jwaisner
Copy link
Member

jwaisner commented Jan 6, 2020

I have tested this item ✅ successfully on 789eabc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jan 6, 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner merged commit 5d03525 into joomla:4.0-dev Jan 6, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 6, 2020
@infograf768
Copy link
Member

@Fedik
To help figure any remaining issue in RTL, what have you remarked? (Please use screenshot)
To be sure, first please patch with #27384

@Fedik Fedik deleted the searchtools-move-to-tmpl branch January 7, 2020 08:39
@Fedik
Copy link
Member Author

Fedik commented Jan 7, 2020

@infograf768 it looks good to me:
LTR:
screen 2020-01-07 11 10 00 1560x281

RTL:
screen 2020-01-07 11 14 15 1570x283

@infograf768
Copy link
Member

Thanks. Remains therefore after #27384 is merged, some aspects from toolbar css dealing with margins in mobile view (rtl/ltr).
Will look at these later.

@infograf768
Copy link
Member

See #27443 for follow-up

brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants