[4.0] Move Searchtools styling to template#27416
Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom Jan 6, 2020
Merged
Conversation
Conflicts: build/media_source/system/joomla.asset.json
Merged
Member
|
Let's go for it. |
Member
|
I have tested this item ✅ successfully on 789eabc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416. |
Member
|
I have tested this item ✅ successfully on 789eabc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416. |
Contributor
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416. |
Member
|
Thanks |
Member
Member
Author
|
@infograf768 it looks good to me: |
Member
|
Thanks. Remains therefore after #27384 is merged, some aspects from toolbar css dealing with margins in mobile view (rtl/ltr). |
Member
|
See #27443 for follow-up |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary of Changes
This will move searchtools styling to the template files.
More info in #27384 comments.
Testing Instructions
Apply patch, run
npm installExpected result
All works
Actual result
Almost works, with some rtl issue
@infograf768 please check