Skip to content

Comments

[4.0] Site/Admin select in searchtools#27388

Closed
brianteeman wants to merge 3 commits intojoomla:4.0-devfrom
brianteeman:site-admin
Closed

[4.0] Site/Admin select in searchtools#27388
brianteeman wants to merge 3 commits intojoomla:4.0-devfrom
brianteeman:site-admin

Conversation

@brianteeman
Copy link
Contributor

see screenshots for changes

If we wait for an expert to fix it then it will never happen

On pages where we still have an admin/site select such as /administrator/index.php?option=com_languages&view=installed&client=1 there is an error in the RTL css that forces it to be full width

Before

image

After

image

see screenshots for changes

If we wait for an expert to fix it then it will never happen

On pages where we still have an admin/site select such as `/administrator/index.php?option=com_languages&view=installed&client=1` there is an error in the RTL css that forces it to be full width

### Before

### After
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Dec 30, 2019
@infograf768
Copy link
Member

That is not enough.
As I said in the other pr for searchtools, we have an issue when reducing the window as we should get float none but the template rtl css does not load after the system css in that case.

@brianteeman
Copy link
Contributor Author

The order that the css is loaded is a different issue.
float: none is completely wrong for a desktop site and that is what this fixes.

(we really should not have a template-rtl.css)

@infograf768
Copy link
Member

It HAS to switch to none when the window is reduced. This pr alone breaks the whole display on mobile. One can’t solve an issue while creating another.
Both situations have to be solved together...

@brianteeman
Copy link
Contributor Author

well before this PR the desktop was broken. I will work on fixing the mobile now

@brianteeman
Copy link
Contributor Author

until someone works out the css ordering this PR now works correctly on mobile as well

@infograf768
Copy link
Member

infograf768 commented Jan 2, 2020

See discussion in #27384
After this is solved, we may have to totally refactor the css for searchtools.
I also informed maintainers about the issue.

Note: yes, the change to mobile with !important works in a similar way as ltr now.

@infograf768
Copy link
Member

Closing as the changes here are included in #27416

@infograf768 infograf768 closed this Jan 6, 2020
@brianteeman brianteeman deleted the site-admin branch January 6, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants