Skip to content

[4.1] Export / Import the database in the admin form#26248

Closed
twister65 wants to merge 62 commits intojoomla:4.1-devfrom
twister65:4.0-dbdump
Closed

[4.1] Export / Import the database in the admin form#26248
twister65 wants to merge 62 commits intojoomla:4.1-devfrom
twister65:4.0-dbdump

Conversation

@twister65
Copy link
Contributor

@twister65 twister65 commented Sep 10, 2019

This pull request aims to export and import all the database in a package (zip file).

Summary of Changes

Add the Export / Import functionality to the System->Database view:
export_import

Testing Instructions

Apply this PR:
1- Click on Export button.
2- Select the zip file downloaded in the import box.
3- Click on Import button.

Expected result

Actual result

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 10, 2019
@brianteeman
Copy link
Contributor

For security purposes I would expect to see the uploaded db dump deleted from the server after it has been used. I would also expect to see some "uniqueness" in the export file name instead of just joomla_db.zip. Probably including the site name and a time stamp.

@brianteeman
Copy link
Contributor

Notice: Constant JPATH_ROOT already defined in C:\htdocs\joomla-cms\administrator\components\com_installer\Model\DatabaseModel.php on line 14

@brianteeman
Copy link
Contributor

Windows cannot open the zip

image

@brianteeman
Copy link
Contributor

Looking at the zip file I can see that it fails to open because at the top of the file before the zipped data is the markup for the html of the page

@wilsonge
Copy link
Contributor

My gut is to close this as it's technically no different to the feature we rejected here #15819 (comment) - Anything you'd like to add that hasn't already been discussed there?

@twister65
Copy link
Contributor Author

This is a gui for PR #24733. This is just a draft and all comments are welcome.

It works with PostgreSQL, but there are some recent bugs when importing into the MySQL database (regardless of this PR).
I hope to do a new PR soon to solve it:
https://github.com/twister65/database/tree/fix-import

@twister65
Copy link
Contributor Author

Referring to @wilsonge comment #26248 (comment), I close this.

Note that postgresql is no longer supported by Akeeba Backup.
If someone needs to do a full backup of his site, he can use phppgadmin to dump the database and tar to archive the files.
So practical ! What good is it to be bored.

@twister65 twister65 closed this Sep 11, 2019
@alikon
Copy link
Contributor

alikon commented Sep 11, 2019

@twister65 at least thanks to your work, we can use the CLI command for this...
btw i disagree with @wilsonge ..... maybe i'm the other postgresql user other than you 😄

@twister65
Copy link
Contributor Author

Bug fixes for the database importer / exporter are here:
joomla-framework/database#191

@twister65
Copy link
Contributor Author

twister65 commented Sep 22, 2019

Reopened for test purposes only, at my convenience.

@twister65 twister65 reopened this Sep 22, 2019
@twister65
Copy link
Contributor Author

Windows cannot open the zip

@brianteeman , could you precise your system informations ?
I tested this without error on Windows 10 and wampserver.

@jaydevingawale
Copy link

I have tested this item ✅ successfully on 5cb9f08

I have tested this and it works successfully, even the downloaded file is also readable.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26248.

@twister65 twister65 marked this pull request as ready for review October 19, 2019 07:41
@berndkohlen
Copy link

I am not shure, that the result is ok
grafik

@twister65
Copy link
Contributor Author

@berndkohlen , please see my previous comment: #26248 (comment)
You also need to apply PR joomla-framework/database#191

@SharayuYadav
Copy link

I have tested this item ✅ successfully on ea0ba05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26248.

1 similar comment
@ttplpoojak
Copy link

I have tested this item ✅ successfully on ea0ba05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26248.

@yasin-96
Copy link

yasin-96 commented Aug 3, 2020

I have tested this item ✅ successfully on bfbf948

Applied patch via patch tester, clicekd the export button, it downloaded the zip file and afterwards I clicekd the import button and selected the downloaded file worked without problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26248.

@jmeintrup
Copy link

I have tested this item ✅ successfully on bfbf948

Tested successfully with MySQL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26248.

@roland-d
Copy link
Contributor

roland-d commented Aug 4, 2020

@twister65 The com_installer.ini was cleaned up in #30162 Can you please fix the conflict?

@twister65 twister65 changed the title [4.0] Export / Import the database in the admin form [4.1] Export / Import the database in the admin form Aug 8, 2020
@twister65 twister65 changed the base branch from 4.0-dev to 4.1-dev August 8, 2020 14:41
@Quy Quy removed the PR-4.0-dev label Aug 9, 2020
@bembelimen bembelimen marked this pull request as draft November 15, 2020 18:40
@twister65 twister65 marked this pull request as ready for review August 21, 2021 14:30
Replace spaces with tabs.
@bembelimen
Copy link
Contributor

Hello,
thanks for your contribution.

As stated already, this PR is in my opinion not an improved solution to #15819 which was rejected for valid reasons. It also has the some additional challenges + e.g. missing the "time out protection". So I close this PR.

@bembelimen bembelimen closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.