Skip to content

[4.0] Split up installer plugin JS#30162

Merged
roland-d merged 16 commits intojoomla:4.0-devfrom
SharkyKZ:j4/js/installer
Aug 4, 2020
Merged

[4.0] Split up installer plugin JS#30162
roland-d merged 16 commits intojoomla:4.0-devfrom
SharkyKZ:j4/js/installer

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jul 22, 2020

Fixes #30017

Summary of Changes

Moves installer plugin JS to separate files for each plugin.
Fixes markup generating empty tabset.
Moves plugin-specific language strings to plugins.

Testing Instructions

node build.js --compile-js required.

  1. Test that all extension install methods still work.
  2. Disable all installer plugins. Go to extension installer.

Actual result BEFORE applying this Pull Request

  1. JS errors:

Uncaught TypeError: document.getElementById(...) is null --- media/com_installer/js/installer.min.js
Uncaught TypeError: i[0] is undefined --- media/vendor/joomla-custom-elements/js/joomla-tab.min.js

Expected result AFTER applying this Pull Request

  1. Works like before.
  2. No JS errors.

Documentation Changes Required

IDK.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jul 22, 2020
SharkyKZ added 3 commits July 22, 2020 09:57
@david0296
Copy link

I have tested this item ✅ successfully on 080e1ef

After applying this PR and running the command, the installer plugins still work and there are no more JS errors


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162.

@jmeintrup
Copy link

I have tested this item ✅ successfully on 080e1ef

Prepatch: Browser Console outputs errors as described
Postpatch: No Errors in Console


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162.

@roland-d roland-d added the RTC This Pull Request is Ready To Commit label Aug 4, 2020
@roland-d roland-d merged commit 5b7eb2c into joomla:4.0-dev Aug 4, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 4, 2020
@Quy Quy added this to the Joomla 4.0 milestone Aug 4, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* Split installer plugin JS

* Remove unused function

* Split installer plugin JS

* Split installer plugin JS

* Rename file

* Correct string

* Replace JText

* Disable language autoloading, clean up strings

* Split installer plugin JS

* Remove tabset when no plugins enabled

* Use static alert

* Add core.js dependency

* CS

* CS

* Hound

* Defer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants