[4.0] Split up installer plugin JS#30162
Merged
roland-d merged 16 commits intojoomla:4.0-devfrom Aug 4, 2020
SharkyKZ:j4/js/installer
Merged
[4.0] Split up installer plugin JS#30162roland-d merged 16 commits intojoomla:4.0-devfrom SharkyKZ:j4/js/installer
roland-d merged 16 commits intojoomla:4.0-devfrom
SharkyKZ:j4/js/installer
Conversation
added 12 commits
July 21, 2020 11:20
Fedik
reviewed
Jul 22, 2020
|
I have tested this item ✅ successfully on 080e1ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162. |
|
I have tested this item ✅ successfully on 080e1ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* Split installer plugin JS * Remove unused function * Split installer plugin JS * Split installer plugin JS * Rename file * Correct string * Replace JText * Disable language autoloading, clean up strings * Split installer plugin JS * Remove tabset when no plugins enabled * Use static alert * Add core.js dependency * CS * CS * Hound * Defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30017
Summary of Changes
Moves installer plugin JS to separate files for each plugin.
Fixes markup generating empty tabset.
Moves plugin-specific language strings to plugins.
Testing Instructions
node build.js --compile-jsrequired.Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
IDK.