Fix Extra Column import since MySQL 8#253
Closed
twister65 wants to merge 2 commits intojoomla-framework:2.0-devfrom
Closed
Fix Extra Column import since MySQL 8#253twister65 wants to merge 2 commits intojoomla-framework:2.0-devfrom
twister65 wants to merge 2 commits intojoomla-framework:2.0-devfrom
Conversation
Contributor
|
See CMS issue joomla/joomla-cms#37662 . |
Contributor
|
i've tested successfully on mysql 8.0.28 (PDO) |
|
Okay @nibra or @HLeithner what is holding this fix back? Its been tested and it seems straightforward. I realize it has the dreaded |
Contributor
|
It's ok for me. Can't tell, why it was overlooked. |
Contributor
|
Nothing form my side. |
Llewellynvdm
approved these changes
Feb 28, 2023
|
I re-based this PR, and merged it into 2.0-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #joomla/joomla-cms#37662
Summary of Changes
MySql 8.0 introduces DEFAULT_GENERATED in the extra column and should be replaced with the default value.
`Extra
Any additional information that is available about a given column. The value is nonempty in these cases:
auto_increment for columns that have the AUTO_INCREMENT attribute.
on update CURRENT_TIMESTAMP for TIMESTAMP or DATETIME columns that have the ON UPDATE CURRENT_TIMESTAMP attribute.
VIRTUAL GENERATED or STORED GENERATED for generated columns.
DEFAULT_GENERATED for columns that have an expression default value.`
See https://dev.mysql.com/doc/refman/8.0/en/show-columns.html
Testing Instructions
php cli/joomla.php database:export --folder=<folder_path>
php cli/joomla.php database:import --folder=<folder_path>
Documentation Changes Required