[4.0] Fix icon width in dropdowns etc

[brianteeman]

This simple PR updates the scss so that the styling for icomoon and fontawesome (icon- and fa-) are the same

Can be tested on the actions dropdown with the batch button

before

after

[Quy]

Move to previous line.

[C-Lodder]

The issue derives from: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_dropdown.scss#L8-L13

It should probably be removed instead

[brianteeman]

@C-Lodder you're the expert but are you sure its not because of the
*margin-right: .3em;

[C-Lodder]

@brianteeman The * before a property is a IE hack...specifically for IE7 if I rightly remember.

The should be removed too but out of scope for the PR

[brianteeman]

sorry I meant the margin-right 0.5

[brianteeman]

@C-Lodder I have updated it - can you confirm its ok now

[C-Lodder]

@brianteeman you should just be able to remove the width and revert your initial changes. It will no doubt effect something else in the CMS but that can be addressed later with a proper fix once found

[brianteeman]

by doing both it avoids the chance of effects elsewhere doesnt it?

[C-Lodder]

Meh I suppose so

[ghost]

Please resolve conflicting files so this PR can get tested at Worldwide Pizza, Bugs & Fun, October 19th

[brianteeman]

@franz-wohlkoenig I really hope it will be tested and merged before then

[Nilesh5995]

I have tested this item 🔴 unsuccessfully on 2f8e5be

Testing in the chrome browser.
It looks like shown in before image. Link - https://user-images.githubusercontent.com/1296369/63854445-17e98200-c995-11e9-843a-9f9b68b7f7d4.png

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[ahghatol]

I have tested this item ✅ successfully on 2f8e5be

Worked

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[riishede]

I have tested this item 🔴 unsuccessfully on 2f8e5be

php: Linux web10 4.1.42-vs2.3.8.6-beng #1 SMP Fri Jul 28 13:09:21 BST 2017 x86_64
dbserver: mysql
dbversion: 5.6.32-1~dotdeb+7.1
dbcollation: latin1_swedish_ci
dbconnectioncollation: utf8mb4_general_ci
phpversion: 7.2.16
server: Apache
sapi_name: cgi-fcgi
version: Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
useragent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:69.0) Gecko/20100101 Firefox/69.0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[Schmidie64]

I have tested this item 🔴 unsuccessfully on 2f8e5be

After activating the patch, no change can be detected.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[brianteeman]

To everyone saying this did not work did you run "npm i" after applying the patch to rebuild the css

[Schmidie64]

strangely, actually i had npm i run. Now it's working.

[Schmidie64]

I have tested this item ✅ successfully on 2f8e5be

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26056.}

[wilsonge]

Thanks!

[brianteeman]

Thanks

[infograf768]

IMHO, this should be reverted as it breaks a lot of stuff for quickicons and dashboards.
See #26741

[infograf768]

Please test #26757