Skip to content

[4.0] Align Batch label in Actions dropdown#26053

Closed
Quy wants to merge 3 commits intojoomla:4.0-devfrom
Quy:actions-batch
Closed

[4.0] Align Batch label in Actions dropdown#26053
Quy wants to merge 3 commits intojoomla:4.0-devfrom
Quy:actions-batch

Conversation

@Quy
Copy link
Contributor

@Quy Quy commented Aug 28, 2019

Summary of Changes

Replace Fontawesome icon to fix Batch label alignment in Actions dropdown

Testing Instructions

Go to Content > Articles
Select an article
Click Actions dropdown
Batch is misaligned

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 964ed86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Aug 28, 2019

I have tested this item ✅ successfully on 964ed86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

@alikon
Copy link
Contributor

alikon commented Aug 28, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 28, 2019
@C-Lodder
Copy link
Member

The whole point of the icon-xxx class in J4 was to prevent B/C breaks for extension developers who are still using Icomoon.

icon-xxx classes in J4 are just wrappers for the fa-xxx class.

So the fact that there is misalignment with one of the icons, means there is a bug within the dropdown SCSS. The icon doesn't need changing.

@infograf768
Copy link
Member

Removing RTC after @C-Lodder comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26053.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 28, 2019
@brianteeman
Copy link
Contributor

@C-Lodder says this is not the correct fix and anyway there are other instances of the fa-square icon not addressed

@brianteeman
Copy link
Contributor

see #26056

@Quy Quy closed this Aug 28, 2019
@Quy Quy deleted the actions-batch branch August 28, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants