[4.0] Revert #26056, solving dropdown batch icon and add module icon#26757
Merged
Quy merged 3 commits intojoomla:4.0-devfrom Oct 23, 2019
Merged
[4.0] Revert #26056, solving dropdown batch icon and add module icon#26757Quy merged 3 commits intojoomla:4.0-devfrom
Quy merged 3 commits intojoomla:4.0-devfrom
Conversation
This was referenced Oct 22, 2019
Member
|
Ideally you want to start moving all core to the I'd suggest finding and properly fixing the core root of the actual problem rather than trying to cover it up |
Member
Author
Contributor
|
I have tested this item ✅ successfully on 30aee16 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 30aee16 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26741
Summary of Changes
Reverts #26056
Changed
fa fa-squaretoicon-squareto solve that batch dropdown icon display issue. THanks @Quy :)Correct alignment of the Dashboard add module
Testing Instructions
Patch. Run npm.
Display
/administrator/index.phpand ckeck quickicons alignment are correctly centered as well as the Add module to the dashboard icon.Display the Content Dashboard and check the alignment of the + icon
Display the Article manager, select an article and check the alignment of the Batch icon.
Before patch
See #26741
After patch