Skip to content

[4.0] Revert #26056, solving dropdown batch icon and add module icon#26757

Merged
Quy merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_quickicons_batch_more
Oct 23, 2019
Merged

[4.0] Revert #26056, solving dropdown batch icon and add module icon#26757
Quy merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_quickicons_batch_more

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Oct 22, 2019

Pull Request for Issue #26741

Summary of Changes

Reverts #26056
Changed fa fa-square to icon-square to solve that batch dropdown icon display issue. THanks @Quy :)
Correct alignment of the Dashboard add module

Testing Instructions

Patch. Run npm.
Display /administrator/index.php and ckeck quickicons alignment are correctly centered as well as the Add module to the dashboard icon.

Display the Content Dashboard and check the alignment of the + icon

Display the Article manager, select an article and check the alignment of the Batch icon.

Before patch

See #26741

After patch

Screen Shot 2019-10-22 at 08 14 36

Screen Shot 2019-10-22 at 08 15 54

Screen Shot 2019-10-22 at 08 15 04

Screen Shot 2019-10-22 at 08 16 22

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 22, 2019
@C-Lodder
Copy link
Member

C-Lodder commented Oct 22, 2019

Ideally you want to start moving all core to the fa class (seeing as svg's won't be accepted). The fa and icon classes should adopt the same CSS (as they are simply mapped rather than a different font set), so there should be no difference between the classes.

I'd suggest finding and properly fixing the core root of the actual problem rather than trying to cover it up

@infograf768
Copy link
Member Author

@C-Lodder
I agree this would be ideal.
I also think it has to be done in a specific PR and I have no idea how to do that.
In the mean while let's just have things work as should as #26056 broke all and I can't make RTL corrections without it.

@Quy
Copy link
Contributor

Quy commented Oct 22, 2019

I have tested this item ✅ successfully on 30aee16


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 30aee16


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 22, 2019
@Quy
Copy link
Contributor

Quy commented Oct 22, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 22, 2019
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 23, 2019
@Quy Quy merged commit e2b623c into joomla:4.0-dev Oct 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 23, 2019
@Quy Quy added this to the Joomla 4.0 milestone Oct 23, 2019
@infograf768 infograf768 deleted the 4.0_quickicons_batch_more branch October 23, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants