Skip to content

added tag filter to category list view#27596

Merged
HLeithner merged 2 commits intojoomla:stagingfrom
SniperSister:3x-categorylisttagfilter
Jan 22, 2020
Merged

added tag filter to category list view#27596
HLeithner merged 2 commits intojoomla:stagingfrom
SniperSister:3x-categorylisttagfilter

Conversation

@SniperSister
Copy link
Contributor

Pull Request for Issue #24398, backported to 3.x as mentioned by @HLeithner in #24550 (comment) .

Summary of Changes

Added the missing field definition to the XML; no other changes required as the actual filtering logic is shared with the blog view and therefore available anyway. Only the UI was missing.

Testing Instructions

  • Create several articles in the same category using various tags
  • Create several Category List menu items for the category using the various tags used previously

Expected result

Filters are applied

Actual result

No filter available

Documentation Changes Required

See https://docs.joomla.org/Help39:Menus_Menu_Item_Article_Category_List

Screenshot needs an update, new filter has to be described.

@astridx
Copy link
Contributor

astridx commented Jan 22, 2020

I have tested this successful

  1. I have created two articles - one with the title one and one with the title two.
  2. I have created two tags - one with the title one and one with the title two.
  3. I applied tag one to article one and tag two to article two.
  4. I want to create a menu item of the type category list an select tags. It was not possible to select tags.
  5. I applied this patch via git fetch origin pull/27596/head:3x-categorylisttagfilter, changed to the branch 3x-categorylisttagfilter with the command git checkout 3x-categorylisttagfilter and it was possible to select tags.
  6. I tested different combinations and everything works well.

@astridx
Copy link
Contributor

astridx commented Jan 22, 2020

I have tested this item ✅ successfully on 3c8631f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27596.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 3c8631f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27596.

@Quy
Copy link
Contributor

Quy commented Jan 22, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27596.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2020
@HLeithner HLeithner merged commit 023f6dd into joomla:staging Jan 22, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2020
@HLeithner
Copy link
Member

Thanks

@HLeithner HLeithner added this to the Joomla! 3.9.15 milestone Jan 22, 2020
@SniperSister SniperSister deleted the 3x-categorylisttagfilter branch March 3, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants