Add more single value headers to the singleValueResponseHeaders array in WebApplication#24429
Merged
HLeithner merged 3 commits intojoomla:stagingfrom Apr 2, 2019
Merged
Conversation
wilsonge
approved these changes
Mar 31, 2019
|
I have tested this item ✅ successfully on 88cfd5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429. |
Contributor
|
I have tested this item ✅ successfully on cbf4bf9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429. |
|
@f-hamel can you please retest? |
Member
|
I tested it successful, thx |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue zero-24/plg_system_httpheader#9
Summary of Changes
Add more single value headers to the singleValueResponseHeaders array in WebApplication
New headers added to the singleValueResponseHeaders array:
Testing Instructions
Expected result
Actual result
Documentation Changes Required
none
Side note
This is not limited to my plugin. Any other plugins setting that headers and even the core is affected by that bug (Pragma) in that specific caching case.
Mention
thanks @f-hamel for finding and reporting this issue. 🎉