Skip to content

Add more single value headers to the singleValueResponseHeaders array in WebApplication#24429

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
zero-24:singleValueResponseHeaders
Apr 2, 2019
Merged

Add more single value headers to the singleValueResponseHeaders array in WebApplication#24429
HLeithner merged 3 commits intojoomla:stagingfrom
zero-24:singleValueResponseHeaders

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Mar 31, 2019

Pull Request for Issue zero-24/plg_system_httpheader#9

Summary of Changes

Add more single value headers to the singleValueResponseHeaders array in WebApplication

New headers added to the singleValueResponseHeaders array:

  • pragma
  • strict-transport-security
  • content-security-policy
  • content-security-policy-report-only
  • x-frame-options
  • x-xss-protection
  • x-content-type-options
  • referrer-policy
  • expect-ct
  • feature-policy

Testing Instructions

Expected result

image

Actual result

image

Documentation Changes Required

none

Side note

This is not limited to my plugin. Any other plugins setting that headers and even the core is affected by that bug (Pragma) in that specific caching case.

Mention

thanks @f-hamel for finding and reporting this issue. 🎉

@ghost
Copy link

ghost commented Mar 31, 2019

I have tested this item ✅ successfully on 88cfd5c

Works fine.
No double headers anymore


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429.

@Quy
Copy link
Contributor

Quy commented Apr 1, 2019

I have tested this item ✅ successfully on cbf4bf9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429.

@ghost
Copy link

ghost commented Apr 1, 2019

@f-hamel can you please retest?

@HLeithner
Copy link
Member

I tested it successful, thx

@HLeithner HLeithner merged commit 5346494 into joomla:staging Apr 2, 2019
@zero-24 zero-24 deleted the singleValueResponseHeaders branch April 2, 2019 16:10
@zero-24
Copy link
Contributor Author

zero-24 commented Apr 2, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants