Skip to content

Add more single value headers to the singleValueResponseHeaders array in WebApplication #24429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 3 commits into from
Apr 2, 2019
Merged

Add more single value headers to the singleValueResponseHeaders array in WebApplication #24429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88cfd5c
add csp and other security headers to the singleValueResponseHeaders
zero-24 Mar 31, 2019
44c12bb
Merge branch 'staging' into singleValueResponseHeaders
zero-24 Apr 1, 2019
cbf4bf9
pragma seams to be lost before the push adding it back
zero-24 Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions libraries/src/Application/WebApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,22 +157,32 @@ class WebApplication extends BaseApplication
*/
private $singleValueResponseHeaders = array(
'status', // This is not a valid header name, but the representation used by Joomla to identify the HTTP Response Code
'Content-Length',
'Host',
'Content-Type',
'Content-Location',
'Date',
'Location',
'Retry-After',
'Server',
'Mime-Version',
'Last-Modified',
'ETag',
'Accept-Ranges',
'Content-Range',
'Age',
'Expires',
'Clear-Site-Data',
'content-length',
'host',
'content-type',
'content-location',
'date',
'location',
'retry-after',
'server',
'mime-version',
'last-modified',
'etag',
'accept-ranges',
'content-range',
'age',
'expires',
'clear-site-data',
'pragma',
'strict-transport-security',
'content-security-policy',
'content-security-policy-report-only',
'x-frame-options',
'x-xss-protection',
'x-content-type-options',
'referrer-policy',
'expect-ct',
'feature-policy',
);

/**
Expand Down Expand Up @@ -740,7 +750,7 @@ public function setHeader($name, $value, $replace = false)
* If ($keys && $replace) it's a replacement and previous have been deleted
* If ($keys && !in_array...) it's a multiple value header
*/
$single = in_array($name, $this->singleValueResponseHeaders);
$single = in_array(strtolower($name), $this->singleValueResponseHeaders);

if ($value && (!$keys || ($keys && ($replace || !$single))))
{
Expand Down