Skip to content

Security headers created twice#14

Closed
conseilgouz wants to merge 1 commit intozero-24:masterfrom
conseilgouz:pmleconte-patch-1
Closed

Security headers created twice#14
conseilgouz wants to merge 1 commit intozero-24:masterfrom
conseilgouz:pmleconte-patch-1

Conversation

@conseilgouz
Copy link

@conseilgouz conseilgouz commented Apr 30, 2019

Hi,

Thank you for this plugin.

When "write header to config file" is set, security headers are created twice : once in .htaccess/web.config file and once in html code.

When looking at your website with https://securityheaders.com/, everything is ok except warnings about duplicate headers.

I'm working with Joomla 3.9.5 which includes joomla/joomla-cms#24429

Pascal

…ed twice : once in .htaccess/web.config file and once in html code.
@zero-24
Copy link
Owner

zero-24 commented May 1, 2019

Hi,

I can not reproduce the problem? Can you please confirm and let me know your cache settings?

@conseilgouz
Copy link
Author

Hi,

Cache is disabled.

Securityheaders.com shows following screens

securityheaders_1

X-frame-options, X-XSS-Protection, ... appear twice and we have the following warnings.

securityheaders_2

Pascal

@zero-24
Copy link
Owner

zero-24 commented May 1, 2019

hmm can you please check the actual htaccess and show me it's contents? Maybe something there is different than on my site or there might be different rules applied with the always keyword. I'm confused because I get the point about setting it twice but it is working on my site and I don't understand why it should behave different on your site than on mine.

@conseilgouz
Copy link
Author

HI,

Taking a look at the code, my patch seems obvious, but, plugin's behaviour is different on some of my website also.

It seems to be related to hoster configuration.

Gandi, OVH hostings give the same problem when 1&1 (Ionos) hosted websites do work fine.

All my websites are working with AESecure to create .htaccess file and use the same template.

@zero-24
Copy link
Owner

zero-24 commented May 5, 2019

Taking a look at the code, my patch seems obvious, but, plugin's behaviour is different on some of my website also.

Well it also disables the csp headers configured as "additional headers" as they are excluded from beeing written to the htaccess, so this would mean that part needs to be rewritten too.

All my websites are working with AESecure to create .htaccess file and use the same template.

I don't know AESecure can you please check the htaccess files whether there are calls to Header always set in that htaccess, maybe some headers are set from the server side too? Given that it works different on different hosts with the same configuration?

Gandi, OVH hostings give the same problem when 1&1 (Ionos) hosted websites do work fine.

I would like to workout what is the problem with the hosts is before applying patches for issues I don't understand, because code wise we seam to be fine as showed by 1&1 and my hoster.

@zero-24
Copy link
Owner

zero-24 commented Aug 17, 2019

7835098 - Removes the option completely

@zero-24 zero-24 closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants