[4.0] Fix media field fails in subform#24362
Closed
Arpit-24 wants to merge 10 commits intojoomla:4.0-devfrom
Closed
[4.0] Fix media field fails in subform#24362Arpit-24 wants to merge 10 commits intojoomla:4.0-devfrom
Arpit-24 wants to merge 10 commits intojoomla:4.0-devfrom
Conversation
Hides the header and options in full screen mode to prevent overlap over the editor area in full-screen mode. Another possible alternative is displaying both the options as well as the editor in full-screen mode but purely a user preference. Because the need for save and other options is not as important in full-screen mode.
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I don't think you're supposed to use jQuery/Bootstrap here. |
ghost
added
the
Contributor
|
Thanks for this commit @Arpit-24 very much appreciated. Regardless of whether there is a patch or not I get this JS error. Nothing happens with the media.
I would assume it is not related to this PR, but perhaps you can provide more informatoin. Could you also address @SharkyKZ point, or ask for clarification if you aren't sure. Again, thanks for your contribution, you are appreciated. |
Quy
added
the
Updates Requested
Contributor
|
Closing for stated reason and confirmed by #23742. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24179 .
Summary of Changes
Replaced custom open and close functions with bootstrap show and hide functions.
Render iframe in modal body, earlier it wasn't