Skip to content

[4.0] Do NOT force jQuery.js and Bootstrap.js in the backend template#23742

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
dgrammatiko:4.0-dev-atum
Feb 22, 2019
Merged

[4.0] Do NOT force jQuery.js and Bootstrap.js in the backend template#23742
wilsonge merged 6 commits intojoomla:4.0-devfrom
dgrammatiko:4.0-dev-atum

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Removed the dictated jQuery.js and Bootstrap.js from the backend template.
  • Reason: almost ALL interactive components for Bootstrap are held by a PHP helper (HTMLHelper::_('bootstrap.something'...)) therefor there is zero benefit forcing these scripts in the index.php of the template. Also we've (as the Javascript team) put a huge amount of work to convert everything to vanilla javascript and quite frankly by forcing jQuery always makes all that work redundant.

Testing Instructions

Check that all pages in the backend still work

Expected result

No change

Actual result

Documentation Changes Required

No. jQuery and Bootstrap.js are still supported and can be loaded whenever they're needed but they're not forced anymore

@wilsonge wilsonge merged commit feeb6b9 into joomla:4.0-dev Feb 22, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 22, 2019
@wilsonge
Copy link
Contributor

Just for the record IF we move to BS5 before stable (and therefore don't have to load jquery) I might reconsider this and revert back to loading bs5.js with the BACKEND template (not the frontend if/when we sort that out)

@dgrammatiko
Copy link
Contributor Author

@wilsonge but the work on the custom elements was primarily to fix the a11y issues of Bootstrap. The vanilla js was a side effect. So falling back to BS is just blindly erase all the hard work done on the accessibility so far...

@dgrammatiko
Copy link
Contributor Author

@Fedik did you just undid this PR with the changes in the assets manager?

@Fedik
Copy link
Member

Fedik commented Jan 8, 2020

what changes? :)
anything can be, there was many changes

@dgrammatiko
Copy link
Contributor Author

You switched back to forcing BS js on the index.php

@Fedik
Copy link
Member

Fedik commented Jan 8, 2020

you mean changes in joomla.asset.json?
well, I did not forcing anything :neckbeard:
there was 1000 merge conflicts in that file, that can accidentally mix the changes

@dgrammatiko
Copy link
Contributor Author

I know, but basically you reverted this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants