[4.0] Remove jQuery and boostrap.js deps for templates (redo of #23742)#27473
[4.0] Remove jQuery and boostrap.js deps for templates (redo of #23742)#27473wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
|
@Fedik I've just tested as described and everything works. The only thing which confuses me a bit is that if I am in backend or in frontend (but in frontend only after having logged in) I can see in network analysis of browser development tools that jquery.min.js and bootstrap.bundle.min.js are still loaded. Is that expected? If yes, I'll give a good test result. Just let me know. Update: Or does it need some special action after having applied the patch e.g. with patchtester? |
|
The jquery.min.js and bootstrap.bundle.min.js still may be loaded, because they requested by other components, layouts etc. The main idea in the patch is that the template does not require these scripts to work, so they should not be set as dependency. |
|
I have tested this item ✅ successfully on 3917a77 In addition, the backend and frontend templates don't load bootstrap and jquery anymore when not being logged in. Only after login when some component requires that, they are loaded. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473. |
|
And to make it complete: Drone failure as usual seems not to be related to this PR. |
|
This breaks menu in frontend. See similar PR #23744. |
|
@SharkyKZ Am just testing again but can't see what's broken. Could you provide some details? |
|
@SharkyKZ it seems on mobile version, I did not noticed, |
|
Ouch, didn't notice that. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473. |
|
Okay I have add bootstrap.js back to cassiopeia, it seems the mobile menu use "navbar-toggler" feature. |
|
I have tested this item ✅ successfully on d7df7b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473. |
1 similar comment
|
I have tested this item ✅ successfully on d7df7b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473. |
|
Thank you @Fedik 🙌 |
|
Thanks! |
|
It is no longer possible to tab between Set 2, Set 1, and Set 0 in the TinyMCE plugin. |
|
need to load bootstrap in that specific layout |
|
Or use the custom elements tabs as the rest of the backend? |
|
when it will stop mess with DOM 😉 |
|
When will it adhere to the standards for CE? (I have no answer for both questions, it seems both issues are due to my bad implementation) |
@Quy Seems I've missed that when testing, shame on me. Will someone make a new issue for that, or even a new PR? |
|
@richard67 I will do PR, but some time later, maybe on the weekend |
|
@richard67 @Quy please test this one #27560 |

Summary of Changes
Remove jQuery and boostrap.js dependencies for a templates.
Partial redo of #23742, that lost somewhere while waiting for #25775
Testing Instructions
Apply patch, and make sure all still works.
Expected result
Works
Actual result
Works
Documentation Changes Required
nope